Status: New
Owner: [hidden email] Labels: Type-Enh New issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629 This enhancements adds possibility to create window group from any system window. It is slightly modified version of Laurent code published in the thread "GroupWindowMorph that can embed any kind of window as tab". system modifications: - adds option "Create window group" to the window menu modifications to the original code: - accept drops only on tabs - move the class to the Category "Morphic-Windows" Attachments: GroupWindowMorph.st 43.5 KB patch.st 2.2 KB _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #1 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629 Beautiful. It would be great to have an immediate feedback when being over the tab bar with a window. Right now, I have to drop the window to see if I hit the bar. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Cc: [hidden email] Comment #2 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629 This version adds a frame as dropping position feedback Attachments: Morphic-Windows-Groups.st 46.8 KB _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixReviewNeeded Labels: Milestone-2.0 Comment #3 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #4 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629 this is cool, but the "undock on close" is unnatural (it should close the window in tab, not just undock) I'll create a new issue for that _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixToInclude Comment #5 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629 new req in http://code.google.com/p/pharo/issues/detail?id=5861 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Workneeded Comment #6 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629 it is using a bad reference to TopWindow (which does not exists). So, is having a undeclared... _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
In reply to this post by pharo
Updates:
Status: FixReviewNeeded Comment #8 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629 remove the TopWindow reference Attachments: patch.2.st 3.0 KB _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: MonkeyIsChecking Comment #9 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629#c9 The Monkey is currently checking this issue. Please don't change it! _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #10 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629 SLICE-Issue-5629-Enh-GroupWindowMorph-PavelKrivanek.1 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: WorkNeeded Comment #11 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629#c11 Monkey went bananas: -------------------- Error while loading "Morphic-Windows-Groups.st" from Comment #2: MessageNotUnderstood: ReadStream>>fileIn 1: ReadStream(Object)>>doesNotUnderstand: #fileIn 2: [attachment contents asString readStream fileIn] in [:attachment | [attachment contents asString readStream fileIn] on: Error do: [:e | self addError: e forFile: attachment description]] in UlysseTheMonkey>>loadChangeSet 3: BlockClosure>>on:do: 4: [:attachment | [attachment contents asString readStream fileIn] on: Error do: [:e | self addError: e forFile: attachment description]] in UlysseTheMonkey>>loadChangeSet 5: Array(SequenceableCollection)>>do: 6: UlysseTheMonkey>>loadChangeSet 7: [self loadChangeSet] in UlysseTheMonkey>>loadAndTestChangeSet 8: [loadStopwatch reset activate. aBlock value. loadStopwatch suspend. testResult := self runTests. self removeFalseErrors] in UlysseTheMonkey>>testChangeImpact: 9: BlockClosure>>on:do: 10: UlysseTheMonkey>>testChangeImpact: ... -------------------- Error while loading "patch.2.st" from Comment #8: MessageNotUnderstood: ReadStream>>fileIn 1: ReadStream(Object)>>doesNotUnderstand: #fileIn 2: [attachment contents asString readStream fileIn] in [:attachment | [attachment contents asString readStream fileIn] on: Error do: [:e | self addError: e forFile: attachment description]] in UlysseTheMonkey>>loadChangeSet 3: BlockClosure>>on:do: 4: [:attachment | [attachment contents asString readStream fileIn] on: Error do: [:e | self addError: e forFile: attachment description]] in UlysseTheMonkey>>loadChangeSet 5: Array(SequenceableCollection)>>do: 6: UlysseTheMonkey>>loadChangeSet 7: [self loadChangeSet] in UlysseTheMonkey>>loadAndTestChangeSet 8: [loadStopwatch reset activate. aBlock value. loadStopwatch suspend. testResult := self runTests. self removeFalseErrors] in UlysseTheMonkey>>testChangeImpact: 9: BlockClosure>>on:do: 10: UlysseTheMonkey>>testChangeImpact: ... -------------------- Error while loading "GroupWindowMorph.st" from Comment #0: MessageNotUnderstood: ReadStream>>fileIn 1: ReadStream(Object)>>doesNotUnderstand: #fileIn 2: [attachment contents asString readStream fileIn] in [:attachment | [attachment contents asString readStream fileIn] on: Error do: [:e | self addError: e forFile: attachment description]] in UlysseTheMonkey>>loadChangeSet 3: BlockClosure>>on:do: 4: [:attachment | [attachment contents asString readStream fileIn] on: Error do: [:e | self addError: e forFile: attachment description]] in UlysseTheMonkey>>loadChangeSet 5: Array(SequenceableCollection)>>do: 6: UlysseTheMonkey>>loadChangeSet 7: [self loadChangeSet] in UlysseTheMonkey>>loadAndTestChangeSet 8: [loadStopwatch reset activate. aBlock value. loadStopwatch suspend. testResult := self runTests. self removeFalseErrors] in UlysseTheMonkey>>testChangeImpact: 9: BlockClosure>>on:do: 10: UlysseTheMonkey>>testChangeImpact: ... -------------------- Error while loading "patch.st" from Comment #0: MessageNotUnderstood: ReadStream>>fileIn 1: ReadStream(Object)>>doesNotUnderstand: #fileIn 2: [attachment contents asString readStream fileIn] in [:attachment | [attachment contents asString readStream fileIn] on: Error do: [:e | self addError: e forFile: attachment description]] in UlysseTheMonkey>>loadChangeSet 3: BlockClosure>>on:do: 4: [:attachment | [attachment contents asString readStream fileIn] on: Error do: [:e | self addError: e forFile: attachment description]] in UlysseTheMonkey>>loadChangeSet 5: Array(SequenceableCollection)>>do: 6: UlysseTheMonkey>>loadChangeSet 7: [self loadChangeSet] in UlysseTheMonkey>>loadAndTestChangeSet 8: [loadStopwatch reset activate. aBlock value. loadStopwatch suspend. testResult := self runTests. self removeFalseErrors] in UlysseTheMonkey>>testChangeImpact: 9: BlockClosure>>on:do: 10: UlysseTheMonkey>>testChangeImpact: ... ---------------------------------------------------------- Loaded Source: SLICE-Issue-5629-Enh-GroupWindowMorph-PavelKrivanek.1 from http://ss3.gemstone.com/ss/PharoInbox "patch.2.st" from Comment #8 "patch.st" from Comment #0 "GroupWindowMorph.st" from Comment #0 "Morphic-Windows-Groups.st" from Comment #2 Tested using Pharo-2.0-20180-a on CoInterpreter VMMaker-oscog-EstebanLorenzano.161 uuid: 8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 3 2012, StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid: 8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 3 2012, https://git.gitorious.org/cogvm/blessed.git Commit: 8028952c1242f72b6d078b8161f310e3bf0cd365 Date: Tue Jul 3 16:26:14 2012 +0200 By: Esteban Lorenzano <[hidden email]> _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixReviewNeeded Comment #12 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: MonkeyIsChecking Comment #13 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629#c13 The Monkey is currently checking this issue. Please don't change it! _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: ValidatedByTheMonkey Labels: CheckedIn20185 Comment #14 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629#c14 This Issue has been checked by Ulysse the Monkey 6365 tests passed in 00:02:01s: =============================== CollectionsTests-Arrayed (547) CollectionsTests-Atomic (12) CollectionsTests-Sequenceable (906) CollectionsTests-SplitJoin (27) CollectionsTests-Stack (16) CollectionsTests-Streams (37) CollectionsTests-Strings (596) CollectionsTests-Support (12) CollectionsTests-Unordered (1951) CollectionsTests-Weak (739) CompilerTests (171) KernelTests-Chronology (577) KernelTests-Classes (66) KernelTests-Exception (2) KernelTests-Methods (171) KernelTests-Numbers (276) KernelTests-Objects (86) KernelTests-Pragmas (3) KernelTests-Processes (31) MorphicTests-Basic (16) MorphicTests-Event (7) MorphicTests-Kernel (8) MorphicTests-Text Support (4) MorphicTests-Widgets (3) MorphicTests-WindowNotification (8) SUnit-Core-Extensions (3) SUnit-Core-Utilities (3) SUnit-Tests-Core (78) Tests-Polymorph-Widgets (9) ---------------------------------------------------------- Loaded Source: SLICE-Issue-5629-Enh-GroupWindowMorph-PavelKrivanek.1 from http://ss3.gemstone.com/ss/PharoInbox "patch.2.st" from Comment #8 "patch.st" from Comment #0 "GroupWindowMorph.st" from Comment #0 "Morphic-Windows-Groups.st" from Comment #2 Tested using Pharo-2.0-20185-a on CoInterpreter VMMaker-oscog-EstebanLorenzano.161 uuid: 8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 5 2012, StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid: 8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 5 2012, https://git.gitorious.org/cogvm/blessed.git Commit: 8216bc960dcf8ddab3a2f6fb54cc97214e7797fd Date: Thu Jul 5 09:41:44 2012 +0200 By: Esteban Lorenzano <[hidden email]> _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: MonkeyIsChecking Comment #15 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629#c15 The Monkey is currently checking this issue. Please don't change it! _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: ValidatedByTheMonkey Labels: CheckedIn20186 Comment #16 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629#c16 This Issue has been checked by Ulysse the Monkey 6381 tests passed in 00:02:03s: =============================== CollectionsTests-Arrayed (547) CollectionsTests-Atomic (12) CollectionsTests-Sequenceable (906) CollectionsTests-SplitJoin (27) CollectionsTests-Stack (16) CollectionsTests-Streams (37) CollectionsTests-Strings (596) CollectionsTests-Support (12) CollectionsTests-Unordered (1951) CollectionsTests-Weak (739) CompilerTests (179) KernelTests-Chronology (577) KernelTests-Classes (67) KernelTests-Exception (2) KernelTests-Methods (178) KernelTests-Numbers (276) KernelTests-Objects (86) KernelTests-Pragmas (3) KernelTests-Processes (31) MorphicTests-Basic (16) MorphicTests-Event (7) MorphicTests-Kernel (8) MorphicTests-Text Support (4) MorphicTests-Widgets (3) MorphicTests-WindowNotification (8) SUnit-Core-Extensions (3) SUnit-Core-Utilities (3) SUnit-Tests-Core (78) Tests-Polymorph-Widgets (9) ---------------------------------------------------------- Loaded Source: SLICE-Issue-5629-Enh-GroupWindowMorph-PavelKrivanek.1 from http://ss3.gemstone.com/ss/PharoInbox "patch.2.st" from Comment #8 "patch.st" from Comment #0 "GroupWindowMorph.st" from Comment #0 "Morphic-Windows-Groups.st" from Comment #2 Tested using Pharo-2.0-20186-a on CoInterpreter VMMaker-oscog-EstebanLorenzano.161 uuid: 8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 5 2012, StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid: 8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 5 2012, https://git.gitorious.org/cogvm/blessed.git Commit: 8216bc960dcf8ddab3a2f6fb54cc97214e7797fd Date: Thu Jul 5 09:41:44 2012 +0200 By: Esteban Lorenzano <[hidden email]> _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixToInclude Comment #17 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Integrated Comment #18 on issue 5629 by [hidden email]: Enh: GroupWindowMorph http://code.google.com/p/pharo/issues/detail?id=5629 in 2.0 187 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Free forum by Nabble | Edit this page |