Issue 5661 in pharo: Clean morphic EventHandler

Status: Accepted
Owner: [hidden email]
Labels: Type-Cleanup Milestone-2.0

New issue 5661 by [hidden email]: Clean morphic EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661

Current implementation:
-does not handle keydown nor keyup
-does not support attaching several handlers to the same event


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #1 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661

First step to replace it by announcements.  A new a bit more clean  
MorphicEventHandler implementation, which supports what it's former version  
didn't support.

Tests attached also.

Attachments:
        eventhandler.3.cs  17.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661

All usages of EventHandler where moved to MorphicEventHandler

Attachments:
        eventHandlerReplacement.2.cs  1.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661

deprecated old event handler

Attachments:
        oldEventHandlerDeprecation.1.cs  922 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #4 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #5 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661#c5

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #6 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661#c6

Monkey went bananas:
--------------------
Error while loading "eventHandlerReplacement.2.cs" from Comment #2:
        MessageNotUnderstood: ReadStream>>fileIn
  1: ReadStream(Object)>>doesNotUnderstand: #fileIn
  2: [attachment contents asString readStream fileIn] in [:attachment |  
[attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
ChangeLoader>>loadChangeSet
  3: BlockClosure>>on:do:
  4: [:attachment | [attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
ChangeLoader>>loadChangeSet
  5: Array(SequenceableCollection)>>do:
  6: ChangeLoader>>loadChangeSet
  7: [self loadChangeSet] in ChangeLoader>>loadAndTestChangeSet
  8: [loadStopwatch reset activate.
                aBlock value.
                loadStopwatch suspend.
                testResult := self runTests.
                self removeFalseErrors] in ChangeLoader>>testChangeImpact:
  9: BlockClosure>>on:do:
10: ChangeLoader>>testChangeImpact:
        ...

--------------------
Error while loading "eventhandler.3.cs" from Comment #1:
        MessageNotUnderstood: ReadStream>>fileIn
  1: ReadStream(Object)>>doesNotUnderstand: #fileIn
  2: [attachment contents asString readStream fileIn] in [:attachment |  
[attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
ChangeLoader>>loadChangeSet
  3: BlockClosure>>on:do:
  4: [:attachment | [attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
ChangeLoader>>loadChangeSet
  5: Array(SequenceableCollection)>>do:
  6: ChangeLoader>>loadChangeSet
  7: [self loadChangeSet] in ChangeLoader>>loadAndTestChangeSet
  8: [loadStopwatch reset activate.
                aBlock value.
                loadStopwatch suspend.
                testResult := self runTests.
                self removeFalseErrors] in ChangeLoader>>testChangeImpact:
  9: BlockClosure>>on:do:
10: ChangeLoader>>testChangeImpact:
        ...

--------------------
Error while loading "oldEventHandlerDeprecation.1.cs" from Comment #3:
        MessageNotUnderstood: ReadStream>>fileIn
  1: ReadStream(Object)>>doesNotUnderstand: #fileIn
  2: [attachment contents asString readStream fileIn] in [:attachment |  
[attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
ChangeLoader>>loadChangeSet
  3: BlockClosure>>on:do:
  4: [:attachment | [attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
ChangeLoader>>loadChangeSet
  5: Array(SequenceableCollection)>>do:
  6: ChangeLoader>>loadChangeSet
  7: [self loadChangeSet] in ChangeLoader>>loadAndTestChangeSet
  8: [loadStopwatch reset activate.
                aBlock value.
                loadStopwatch suspend.
                testResult := self runTests.
                self removeFalseErrors] in ChangeLoader>>testChangeImpact:
  9: BlockClosure>>on:do:
10: ChangeLoader>>testChangeImpact:
        ...
----------------------------------------------------------
Loaded Source:
        "eventhandler.3.cs" from Comment #1
        "oldEventHandlerDeprecation.1.cs" from Comment #3
        "eventHandlerReplacement.2.cs" from Comment #2
Tested using Pharo-2.0-20172-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #7 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661

monkey, try again, you were broken


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #8 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661#c8

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #9 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661#c9

Monkey went bananas:
--------------------
Error while loading "eventhandler.3.cs" from Comment #1:
        MessageNotUnderstood: ReadStream>>fileIn
  1: ReadStream(Object)>>doesNotUnderstand: #fileIn
  2: [attachment contents asString readStream fileIn] in [:attachment |  
[attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
UlysseTheMonkey>>loadChangeSet
  3: BlockClosure>>on:do:
  4: [:attachment | [attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
UlysseTheMonkey>>loadChangeSet
  5: Array(SequenceableCollection)>>do:
  6: UlysseTheMonkey>>loadChangeSet
  7: [self loadChangeSet] in UlysseTheMonkey>>loadAndTestChangeSet
  8: [loadStopwatch reset activate.
                aBlock value.
                loadStopwatch suspend.
                testResult := self runTests.
                self removeFalseErrors] in UlysseTheMonkey>>testChangeImpact:
  9: BlockClosure>>on:do:
10: UlysseTheMonkey>>testChangeImpact:
        ...

--------------------
Error while loading "oldEventHandlerDeprecation.1.cs" from Comment #3:
        MessageNotUnderstood: ReadStream>>fileIn
  1: ReadStream(Object)>>doesNotUnderstand: #fileIn
  2: [attachment contents asString readStream fileIn] in [:attachment |  
[attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
UlysseTheMonkey>>loadChangeSet
  3: BlockClosure>>on:do:
  4: [:attachment | [attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
UlysseTheMonkey>>loadChangeSet
  5: Array(SequenceableCollection)>>do:
  6: UlysseTheMonkey>>loadChangeSet
  7: [self loadChangeSet] in UlysseTheMonkey>>loadAndTestChangeSet
  8: [loadStopwatch reset activate.
                aBlock value.
                loadStopwatch suspend.
                testResult := self runTests.
                self removeFalseErrors] in UlysseTheMonkey>>testChangeImpact:
  9: BlockClosure>>on:do:
10: UlysseTheMonkey>>testChangeImpact:
        ...

--------------------
Error while loading "eventHandlerReplacement.2.cs" from Comment #2:
        MessageNotUnderstood: ReadStream>>fileIn
  1: ReadStream(Object)>>doesNotUnderstand: #fileIn
  2: [attachment contents asString readStream fileIn] in [:attachment |  
[attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
UlysseTheMonkey>>loadChangeSet
  3: BlockClosure>>on:do:
  4: [:attachment | [attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
UlysseTheMonkey>>loadChangeSet
  5: Array(SequenceableCollection)>>do:
  6: UlysseTheMonkey>>loadChangeSet
  7: [self loadChangeSet] in UlysseTheMonkey>>loadAndTestChangeSet
  8: [loadStopwatch reset activate.
                aBlock value.
                loadStopwatch suspend.
                testResult := self runTests.
                self removeFalseErrors] in UlysseTheMonkey>>testChangeImpact:
  9: BlockClosure>>on:do:
10: UlysseTheMonkey>>testChangeImpact:
        ...
----------------------------------------------------------
Loaded Source:
        "eventhandler.3.cs" from Comment #1
        "oldEventHandlerDeprecation.1.cs" from Comment #3
        "eventHandlerReplacement.2.cs" from Comment #2
Tested using Pharo-2.0-20178-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jul  3 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jul  3 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #10 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661

Slice in inbox.  It adds:
- multiple event handlers can be attached to a morph
- keydown and keyup are now supported
- tests


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #11 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661#c11

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #12 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661#c12

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-5661-Clean-morphic-EventHandler--GuillermoPolito.2 from  
http://ss3.gemstone.com/ss/PharoInbox:
        UndeclaredVariableWarning
  1: EncoderForV3PlusClosures(Encoder)>>undeclared:
  2: Parser>>correctVariable:interval:
  3: [self
                        correctVariable: varName
                        interval: (varStart to: varEnd)] in Parser>>variable
  4: [(self
                                lookupInPools: name
                                ifFound: [:assoc | varNode := self global: assoc name: name])
                        ifTrue: [varNode]
                        ifFalse: [^ action value]] in  
EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  5: Dictionary>>at:ifAbsent:
  6: EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  7: Parser>>variable
  8: Parser>>expression
  9: Parser>>statements:innerBlock:blockNode:
10: Parser>>statements:innerBlock:
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-5661-Clean-morphic-EventHandler--GuillermoPolito.2 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20227-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 19 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 19 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
5151310c41b08f55b70e9c6250711cb1f3672ce7 Date: 2012-07-18 14:06:15 +0200  
By: Camillo Bruni <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #13 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #14 on issue 5661 by [hidden email]: Clean morphic EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661

the slice is outdated, please upload a new one


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #16 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661#c16

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #17 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #18 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #19 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661#c19

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20233

Comment #20 on issue 5661 by [hidden email]: Clean morphic  
EventHandler
http://code.google.com/p/pharo/issues/detail?id=5661#c20

This Issue has been checked by Ulysse the Monkey
       
6395 tests passed in 00:02:12s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        Deprecated20 (7)
        KernelTests-Chronology (583)
        KernelTests-Classes (66)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        MorphicTests-Basic (16)
        MorphicTests-Kernel (8)
        MorphicTests-Text Support (4)
        MorphicTests-Widgets (3)
        MorphicTests-WindowNotification (8)
        Nautilus-Tests (8)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Polymorph-Widgets (10)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-5661-Clean-morphic-EventHandler--GuillermoPolito.3 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20233-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 19 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 19 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
5151310c41b08f55b70e9c6250711cb1f3672ce7 Date: 2012-07-18 14:06:15 +0200  
By: Camillo Bruni <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker