Issue 5679 in pharo: Removing a trait does not remove trait methods from class

Status: New
Owner: ----
Labels: Milestone-2.0 Type-Bug Milestone-1.4

New issue 5679 by [hidden email]: Removing a trait does not remove  
trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

1- Create trait T with method m
2- Create class C that uses T
3- remove T from C

Method m remains available in C




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Duplicate
        Mergedinto: 5722

Comment #1 on issue 5679 by [hidden email]: Removing a trait does  
not remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Accepted
        Mergedinto:

Comment #2 on issue 5679 by [hidden email]: Removing a trait does  
not remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

Hmm, similar but not the same issue.  Simple script to reproduce it (to  
build a test from :) ):

Trait named: #TAAA
        uses: {}
        category: 'AAA'.
TAAA compile: 'm1 ^1' classified: 'test'.

Object subclass: #AAA
        uses: TAAA
        instanceVariableNames: ''
        classVariableNames: ''
        poolDictionaries: ''
        category: 'AAA'.

AAA removeFromComposition: TAAA.
AAA localSelectors -> a Set(#m1)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: marianopeck

Comment #3 on issue 5679 by [hidden email]: Removing a trait does  
not remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

In pharo 1.2.1 and 1.3 works.

It seems that #hasTraitComposition has changed in 1.4, causing this problem.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5679 by [hidden email]: Removing a trait does  
not remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

BTW, the current semantics of hasTraitComposition, introduced in  
http://code.google.com/p/pharo/issues/detail?id=4700 seems the right one,  
so users has to be fixed.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #5 on issue 5679 by [hidden email]: Removing a trait does  
not remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

This changeset fixes some users.  I couldn't find others with problems.

review?

Attachments:
        trait fixes.2.cs  2.5 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 5679 by marianopeck: Removing a trait does not remove  
trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

I did the review together with Guille. We believe this is fine. And fixes  
the problem.
It would be nice to have a unit test for it ;)  But first lets integrat  
this.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 5679 by [hidden email]: Removing a trait does  
not remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

in 2.0 031


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FailingTest

Comment #8 on issue 5679 by [hidden email]: Removing a trait does  
not remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

The build server still crashes when running all tests.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5679 by [hidden email]: Removing a trait does  
not remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

See

https://ci.lille.inria.fr/pharo/view/Pharo%202.0/job/Pharo-2.0-Tests/Architecture=32,OS=linux/23/console


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 5679 by [hidden email]: Removing a trait  
does not remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

Actually, the crashes are because of this issue:  
http://code.google.com/p/pharo/issues/detail?id=5722 :)

They were related, but not the same.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Labels: -Milestone-2.0

Comment #11 on issue 5679 by [hidden email]: Removing a trait does  
not remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5679 by marianopeck: Removing a trait does not remove  
trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

so we close this issue?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #13 on issue 5679 by [hidden email]: Removing a trait  
does not remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

It should be backported, it's an ugly issue that makes traits a non-sense  
in 1.4.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 5679 by marianopeck: Removing a trait does not remove  
trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

+1 this should be backported to 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #15 on issue 5679 by [hidden email]: Removing a trait does not  
remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

it needs to be tested in 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #16 on issue 5679 by [hidden email]: Removing a trait does not  
remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #17 on issue 5679 by [hidden email]: Removing a trait does not  
remove trait methods from class
http://code.google.com/p/pharo/issues/detail?id=5679

in 14442


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker