Issue 5689 in pharo: remove #checkOKToAdd:at:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5689 in pharo: remove #checkOKToAdd:at:

pharo
Status: FixReviewNeeded
Owner: [hidden email]
Labels: Type-Cleanup Milestone-2.0

New issue 5689 by [hidden email]: remove #checkOKToAdd:at:
http://code.google.com/p/pharo/issues/detail?id=5689

it used to be that changes had an upper limit for file size, therefore  
#checkOKToAdd:at: was called to check
if that limit would be reached.

#checkOKToAdd:at: just returns self now, so this is not needed.

The attached change set removes the methods and cleans the senders. No  
deprecation as this is not
an external API method.

Attachments:
        CleanCheckOKToAdd.2.cs  5.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5689 in pharo: remove #checkOKToAdd:at:

pharo
Updates:
        Status: FixToInclude

Comment #1 on issue 5689 by [hidden email]: remove #checkOKToAdd:at:
http://code.google.com/p/pharo/issues/detail?id=5689

Tested it doing a fileout + filein of the fileouted, since there are no  
tests and they are a pain :).

It worked.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5689 in pharo: remove #checkOKToAdd:at:

pharo
Updates:
        Status: Integrated

Comment #2 on issue 5689 by [hidden email]: remove #checkOKToAdd:at:
http://code.google.com/p/pharo/issues/detail?id=5689

in 2.0 016


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker