Issue 5722 in pharo: Be able to remove traits from class definition

Comment #20 on issue 5722 by marianopeck: Be able to remove traits from  
class definition
http://code.google.com/p/pharo/issues/detail?id=5722

So the only test we break with any of these solutions is  
#testChangeSuperclass
And if I try to debug it I have an infinitive loop... so...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #21 on issue 5722 by [hidden email]: Be able to remove  
traits from class definition
http://code.google.com/p/pharo/issues/detail?id=5722

?

In a clean just updated 2.0 image I have all Test-Traits green except for  
#testOriginWithRequiredMethod.

They are halting in #packageFromOrganizer: because of  
Rpackage+Announcements, but the test runs ok.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-2.0

Comment #22 on issue 5722 by [hidden email]: Be able to remove  
traits from class definition
http://code.google.com/p/pharo/issues/detail?id=5722

yes, looks good for 2.0...

For 2.0: change the code to the better solution

For 1.4: Do we backport?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #23 on issue 5722 by marianopeck: Be able to remove traits from  
class definition
http://code.google.com/p/pharo/issues/detail?id=5722

Hi Marcus. No, this issue is not important to backport (since it was never  
supported). However, to conclude the issue, I would integrate the version  
that does:  class ifNotNil:  [ class setTraitComposition: {}  
asTraitComposition ]. , that is:

subclass: t instanceVariableNames: f classVariableNames: d  
poolDictionaries: s category: cat
        "This is the standard initialization message for creating a new class as a
        subclass of an existing class (the receiver)."
        | class |
        class := (ClassBuilder new)
                superclass: self
                subclass: t
                instanceVariableNames: f
                classVariableNames: d
                poolDictionaries: s
                category: cat.
        class ifNotNil:  [ class setTraitComposition: {} asTraitComposition ].
        ^ class


What we should backport is issue  
http://code.google.com/p/pharo/issues/detail?id=5679




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #24 on issue 5722 by [hidden email]: Be able to remove  
traits from class definition
http://code.google.com/p/pharo/issues/detail?id=5722

yes, yes, I attach the changeset with the sexy version.

Attachments:
        remove trait from class definition.2.cs  641 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #25 on issue 5722 by [hidden email]: Be able to remove  
traits from class definition
http://code.google.com/p/pharo/issues/detail?id=5722

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-2.0

Comment #26 on issue 5722 by [hidden email]: Be able to remove  
traits from class definition
http://code.google.com/p/pharo/issues/detail?id=5722

in 2.0 034

TODO: 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #27 on issue 5722 by [hidden email]: Be able to remove traits  
from class definition
http://code.google.com/p/pharo/issues/detail?id=5722

it needs to be tested in 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #28 on issue 5722 by [hidden email]: Be able to remove traits  
from class definition
http://code.google.com/p/pharo/issues/detail?id=5722

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #29 on issue 5722 by [hidden email]: Be able to remove traits  
from class definition
http://code.google.com/p/pharo/issues/detail?id=5722

in 14442


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker