Issue 5740 in pharo: Clean up Temp Embedding 1): Traits

Status: FixReviewNeeded
Owner: [hidden email]
Labels: Type-Cleanup Milestone-2.0

New issue 5740 by [hidden email]: Clean up Temp Embedding 1): Traits
http://code.google.com/p/pharo/issues/detail?id=5740

--> add CompiledMethod>>#copyWithSource:
--> remove #copyWithTempNames: (non general Method not useful anymore)
--> #dropSourcePointer can now use #copyWithSource:
--> remove #zapSourcePointer (same as #destroySourcePointer)
--> in TraitMethodDescription:
        --> #requiredMethod just returns the generated method, no need for
                #copyWithTempNames:
        --> embedd source for the generated method by calling #generateWithSource

Second cs:

--> simplify #generateWithSource and #generateWithTempNames by calling  
#generate, not #generate:using:

Attachments:
        CleanTempEmbeddingTraits.1.cs  2.2 KB
        SimplifyGenerateWithSource.cs  591 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5740 by [hidden email]: Clean up Temp Embedding  
1): Traits
http://code.google.com/p/pharo/issues/detail?id=5740

better names.

zapSourcePointer was good, dropSourcePointer is not saying anything

Attachments:
        RenameSomeMethods.1.cs  1.5 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #3 on issue 5740 by [hidden email]: Clean up Temp Embedding  
1): Traits
http://code.google.com/p/pharo/issues/detail?id=5740

in 2.0 036


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker