Status: FixReviewNeeded
Owner:
[hidden email]
Labels: Type-Cleanup Milestone-2.0
New issue 5744 by
[hidden email]: Clean up Temp Embedding 2): DoIts
http://code.google.com/p/pharo/issues/detail?id=5744- Doits are now compiled with source embedded
- embedding sources for doits pretty prints from AST as doits are compiled
with a return
CompiledMethod:
- remove blockExtendsToTempsMap: Not needed anymore, all calls go the
MethodNode
- remove #copyWitTempsFromMethodNode: All senders use #copyWithSource
- remove #holdsTempNames. Temp name embedding not needed
- add isDoit
- schematicTempNamesString always returns the schematic string
representation of all temps
- tempNames forwards to methodNode (not correct yet but the best we can do)
- remove tempNamesString. Concatenate yourself if you need that.
Debugger>>selectedMessage asks the selectedContext directly for the source.
No need for the methodMap.
DebuggerMethodMap
- no special handling of methods that encode temps. Just compile allways.
MethodNode
- generateWithSource. embedd pretty printed code in case of doit
- remove generateWitTempNames
In general: rewrite code to use #generateWithSource
(to be filed in after Issue 5740)
Attachments:
CleanTempEmbedding.6.cs 13.8 KB
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Locked
