Issue 5746 in pharo: Add announcer inst var into morph

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5746 in pharo: Add announcer inst var into morph

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Feature Milestone-2.0

New issue 5746 by [hidden email]: Add announcer inst var into morph
http://code.google.com/p/pharo/issues/detail?id=5746

so we can start putting interesting stuff with it :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5746 in pharo: Add announcer inst var into morph

pharo
Updates:
        Status: FixReviewNeeded
        Cc: [hidden email]

Comment #1 on issue 5746 by [hidden email]: Add announcer inst var  
into morph
http://code.google.com/p/pharo/issues/detail?id=5746

The following script intends to do it silently.  After an exception raised  
from the progress bar (because it got stupid in the middle of the inst var  
change probably) everything seems to work fine so far.

I've run morphic tests and they are green.

Please, someone review it because I know adding an inst var into morph can  
be dangerous :).

Attachments:
        add announcer inst var.st  165 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5746 in pharo: Add announcer inst var into morph

pharo

Comment #2 on issue 5746 by [hidden email]: Add announcer inst var  
into morph
http://code.google.com/p/pharo/issues/detail?id=5746

should that really be in morph? Do all morphs need that? Can't it be in  
MorphExtension? Maybe even
as a property?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5746 in pharo: Add announcer inst var into morph

pharo

Comment #3 on issue 5746 by [hidden email]: Add announcer inst  
var into morph
http://code.google.com/p/pharo/issues/detail?id=5746

Hmm, I don't see any difference between having it as an inst var or as a  
property in the morphExtension other than the announcer inst var is  
explicit and the extension is not :/.

But I can live with the extension so far, if we want we can change it  
later :).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5746 in pharo: Add announcer inst var into morph

pharo

Comment #4 on issue 5746 by [hidden email]: Add announcer inst  
var into morph
http://code.google.com/p/pharo/issues/detail?id=5746

Here is the alternative implementation using the MorphExtension

Attachments:
        announcer with property.1.cs  248 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5746 in pharo: Add announcer inst var into morph

pharo
Updates:
        Status: FixToInclude

Comment #5 on issue 5746 by [hidden email]: Add announcer inst var  
into morph
http://code.google.com/p/pharo/issues/detail?id=5746

let do it for now as a property.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5746 in pharo: Add announcer inst var into morph

pharo
Updates:
        Status: Integrated

Comment #6 on issue 5746 by [hidden email]: Add announcer inst var  
into morph
http://code.google.com/p/pharo/issues/detail?id=5746

in 2.0 035


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker