Issue 5748 in pharo: Better modularization for Ring packages

Status: Accepted
Owner: marianopeck
Labels: Type-Bug

New issue 5748 by marianopeck: Better modularization for Ring packages
http://code.google.com/p/pharo/issues/detail?id=5748

Hi guys. Ring depends on Monticello and PackageInfo and we want to  
integrate Ring core in PharoKernel since this package is needed to  
serialize/materialize classes and traits. To do that, we need to split Ring  
core in some more packages.

I will publish a slice.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email] [hidden email]
        Labels: -Type-Bug Type-Enh Milestone-2.0

Comment #1 on issue 5748 by marianopeck: Better modularization for Ring  
packages
http://code.google.com/p/pharo/issues/detail?id=5748

So I did it. I move Monticello related stuff to a NEW package  
RingMonticello, and I moved the dependency of PackageInfo to  
Ring-Core-Containers because it makes sense.
So now we can include Ring-Core-Kernel in PharoKernel.

Can someone review?  Fix in inbox.

Name:  
SLICE-Issue-5748-Better-modularization-for-Ring-packages-MarianoMartinezPeck.3
Author: MarianoMartinezPeck
Time: 30 April 2012, 12:41:31.076 pm
UUID: 3a60abba-a932-4578-ab06-79dbe921646b
Ancestors:  
SLICE-Issue-5748-Better-modularization-for-Ring-packages-MarianoMartinezPeck.2
Dependencies: Ring-Core-Containers-MarianoMartinezPeck.12,  
Ring-Core-Kernel-MarianoMartinezPeck.48,  
RingMonticello-MarianoMartinezPeck.2

fix to issue 5748


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5748 by [hidden email]: Better modularization  
for Ring packages
http://code.google.com/p/pharo/issues/detail?id=5748

I would prefer the package name Ring-Monticello to be consistent.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5748 by marianopeck: Better modularization for Ring  
packages
http://code.google.com/p/pharo/issues/detail?id=5748

but don't we have that problem where Monticello gets stupid with the '-'  
because it confuses categories with packages?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5748 by [hidden email]: Better modularization  
for Ring packages
http://code.google.com/p/pharo/issues/detail?id=5748

No, only in case there would be a package with shorter name (i.e. Ring)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5748 by marianopeck: Better modularization for Ring  
packages
http://code.google.com/p/pharo/issues/detail?id=5748

Pavel, I did a second version with Ring-Monticello...but the package rename  
does not work wit extensions. Can you confirm it is fine?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5748 by marianopeck: Better modularization for Ring  
packages
http://code.google.com/p/pharo/issues/detail?id=5748

sorry:

Name:  
SLICE-Issue-5748-Better-modularization-for-Ring-packages-v2-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 30 April 2012, 3:19:30.274 pm
UUID: 5d8816b2-759a-48b5-8bdb-0fba8d301b61
Ancestors:
Dependencies: Ring-Core-Containers-MarianoMartinezPeck.13,  
Ring-Core-Kernel-MarianoMartinezPeck.49,  
Ring-Monticello-MarianoMartinezPeck.1

rename RingMonticello to Ring-Monticello


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #7 on issue 5748 by marianopeck: Better modularization for Ring  
packages
http://code.google.com/p/pharo/issues/detail?id=5748

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #8 on issue 5748 by [hidden email]: Better modularization for  
Ring packages
http://code.google.com/p/pharo/issues/detail?id=5748

Mariano,

Before integrating Ring into Pharo 1.4 I had several packages including the  
original Ring-MC-Extensions for this purpose exactly (see Ring repo), but  
Stephane did not want to have multiple packages for Ring and I had to move  
all the extensions to core and kernel packages and deprecate the other  
packages.

In any case, I also like to have the extensions in a separate package...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5748 by marianopeck: Better modularization for Ring  
packages
http://code.google.com/p/pharo/issues/detail?id=5748

Thanks Veronica. So I will convince stef:  This is easy: Fuel  
materialization for classes and traits depend on Ring, because of  
#collectMethodsFor:into:. If Ring repends on Monticello and Package info,  
it means that Fuel materialization of classes depends on them also, and  
hence cannot be included in a Kernel image.

If the pcakge is called Ring-Core-Kernel, then it should NOT be coupled  
with Monticello. If you want to do that, then put another name to the  
package.

I am sure Stef will agree :)  let's see.

thanks


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 5748 by [hidden email]: Better modularization  
for Ring packages
http://code.google.com/p/pharo/issues/detail?id=5748

Ok for me :)
what we will have to change in the future is that traits depend on ring and  
this is not good because ring should not be in the core. Just a loadable  
metamodel.

Stef


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 5748 by [hidden email]: Better modularization  
for Ring packages
http://code.google.com/p/pharo/issues/detail?id=5748

in 20082


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5748 by [hidden email]: Better modularization  
for Ring packages
http://code.google.com/p/pharo/issues/detail?id=5748

Mariano could you have a look at 20082 because I would like to be sure that  
I do not miss anything.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #13 on issue 5748 by [hidden email]: Better modularization  
for Ring packages
http://code.google.com/p/pharo/issues/detail?id=5748

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 5748 by marianopeck: Better modularization for Ring  
packages
http://code.google.com/p/pharo/issues/detail?id=5748

Hi. I tried to see if it was fine but I cannot do nothing in the image that  
I get

DisplayScreen class(Object)>>doesNotUnderstand: #forceToScreen:


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker