Issue 5751 in pharo: SUnit-UI Interaction refactor

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Milestone-1.4 Type-Enh Difficulty-Easy

New issue 5751 by [hidden email]: SUnit-UI Interaction refactor
http://code.google.com/p/pharo/issues/detail?id=5751

This fragent (and all its implications) of code avoid me to get a simple  
point to add type inference cause is stoling behavior from TestSuite and  
merging it with ui-update behaviors :(

basicRunSuite: aTestSuite do: aBlock
        | testBlock |
        self basicSetUpSuite: aTestSuite.
        testBlock := [:test | test selector
                                displayProgressFrom: 0
                                to: 2
                                during: [:bar |
                                        bar value: test selector asString.
                                        Delay forMilliseconds: 0.0001.
                                        aBlock value: test]].
        [self
                runTestSuite: aTestSuite
                using: testBlock
                displayingProgress: aTestSuite name]
                ensure: [self basicTearDownSuite: aTestSuite]


I propose to use a observer for the updating issues, transfer the setUp and  
tearDown behavior to the TestSuite (with the ensure behavior too) and adapt  
the callers to the new use.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5751 by [hidden email]: SUnit-UI Interaction  
refactor
http://code.google.com/p/pharo/issues/detail?id=5751

Slice in inbox:  
SLICE-Issue-5751-SUnit-UI-Interaction-refactor-SantiagoBragagnolo.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5751 by [hidden email]: SUnit-UI Interaction  
refactor
http://code.google.com/p/pharo/issues/detail?id=5751

You made the slice in 1.4 ¬¬.  I'll review it and adapt it to latest 2.0.

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Cc: [hidden email]
        Labels: -Milestone-1.4 Milestone-2.0

Comment #3 on issue 5751 by [hidden email]: SUnit-UI Interaction  
refactor
http://code.google.com/p/pharo/issues/detail?id=5751

New version in inbox, adapted for 2.0

Ben, probably with this integrated you can simplify the nautilus test  
plugin to use a testsuite instead of running the set of tests by hand.

Name: SLICE-Issue-5751-SUnit-UI-Interaction-refactor-GuillermoPolito.1
Author: GuillermoPolito
Time: 30 April 2012, 8:33:41.456 pm
UUID: ce629f12-6579-4e95-8688-f4f2b7151b12
Ancestors:
Dependencies: SUnit-Core-GuillermoPolito.16, SUnit-UI-GuillermoPolito.20

adapted to 2.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #4 on issue 5751 by [hidden email]: SUnit-UI Interaction  
refactor
http://code.google.com/p/pharo/issues/detail?id=5751

not yet.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #5 on issue 5751 by [hidden email]: SUnit-UI Interaction  
refactor
http://code.google.com/p/pharo/issues/detail?id=5751

This is the right one.  Tested by running ~2000 tests in the test runner.

Name: SLICE-Issue-5751-SUnit-UI-Interaction-refactor-GuillermoPolito.2
Author: GuillermoPolito
Time: 30 April 2012, 8:53:00.69 pm
UUID: 424d0dc8-b43c-4050-8a6e-987827f04327
Ancestors: SLICE-Issue-5751-SUnit-UI-Interaction-refactor-GuillermoPolito.1
Dependencies: SUnit-Core-GuillermoPolito.17, SUnit-UI-GuillermoPolito.20

little fix


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #6 on issue 5751 by [hidden email]: SUnit-UI Interaction  
refactor
http://code.google.com/p/pharo/issues/detail?id=5751

in 2.0 049


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker