Issue 5755 in pharo: Failing Tests: RPackageMCSynchronisationTest

Status: FailingTest
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 5755 by [hidden email]: Failing Tests:  
RPackageMCSynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=5755



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5755 by [hidden email]: Failing Tests:  
RPackageMCSynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=5755

Working on that.
What is strange is that if I run the test once, it is executed three times.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5755 by [hidden email]: Failing Tests:  
RPackageMCSynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=5755

No in fact the test is executed once but some announcement three times.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5755 by [hidden email]: Failing Tests:  
RPackageMCSynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=5755

NautilusMCBindings>>registerToMCAnnouncements

        MonticelloAnnouncer announcer weak
                on: MCWorkingCopyCreated send: #mcWorkingCopyCreated: to: self;
                on: MCWorkingCopyDeleted send: #mcWorkingCopyDeleted: to: self


And
AbstractNautilusUI>>registerToAnnouncements
         ....
        MonticelloAnnouncer announcer weak
                on: MCVersionCreated send: #newMCVersion: to: self;
                on: MCPackageModified send: #mcPackageModified: to: self;
                on: MCWorkingCopyCreated send: #mcWorkingCopyCreated: to: self;
                on: MCWorkingCopyDeleted send: #mcWorkingCopyDeleted: to: self.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5755 by [hidden email]: Failing Tests:  
RPackageMCSynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=5755

This method is executed when a WorkingCopy is created.
Now for now it does not work because the package does not exist. Normally  
it should.



mcWorkingCopyCreated: anAnnouncement
        | package rpackage mcPackage |
       
        package := anAnnouncement package.
        package ifNil: [ ^ self ].
        rpackage := RPackageOrganizer default packageNamed: package name.
        mcPackage := bindingsRtoMC at: rpackage ifAbsent: [ ^ self ].
        (bindingsMCtoR at: mcPackage) do: [:pck | bindingsRtoMC removeKey: pck  
ifAbsent: []]







_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5755 by [hidden email]: Failing Tests:  
RPackageMCSynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=5755

So this is not due to nautilus notification. Because it would be Nautilus  
that gets a problem.
Now

MCWorkingCopy forPackage: (MCPackage new name: #AAAAA34654654).

RPackageOrganizer default includesPackageNamed: #AAAAA34654654
   true

so may be the bug is in the test and the clean up of the Organizer created.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5755 by [hidden email]: Failing Tests:  
RPackageMCSynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=5755

Ok so apparently we get a problem because the test is made to work in  
isolation but the introduction of MonticelloAnnouncer changed the game.  
Indeed during the test we want to test that a special and independent  
RPackageOrganiser got populated when a new package is created. Now since  
MCWorkingCopy will announce event to registrant, and that for example such  
object can check in the default PackageOrganizer they will see
that the package has not been created.

Now first I do not see why Nautilus receives events even when it is not  
open.
Second we should find a way to tell to MCWorkingCopy to be quite during a  
given period of time.





_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #7 on issue 5755 by [hidden email]: Failing Tests:  
RPackageMCSynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=5755

in  
SLICE-Issue-5755-Failing-Tests-RPackageMCSynchronisationTest-EstebanLorenzano.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #8 on issue 5755 by [hidden email]: Failing Tests:  
RPackageMCSynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=5755

there was an remaining undeclared

fix in  
SLICE-Issue-5755-Failing-Tests-RPackageMCSynchronisationTest-EstebanLorenzano.2


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5755 by [hidden email]: Failing Tests:  
RPackageMCSynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=5755

was cool to tripple program :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 5755 by [hidden email]: Failing Tests:  
RPackageMCSynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=5755

in 20092


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker