Issue 5763 in pharo: ProtoObject>>#~~ cleanup

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5763 in pharo: ProtoObject>>#~~ cleanup

pharo
Status: Accepted
Owner: [hidden email]
Labels: Milestone-2.0 Type-Cleanup

New issue 5763 by [hidden email]: ProtoObject>>#~~ cleanup
http://code.google.com/p/pharo/issues/detail?id=5763

Redundant test logic


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5763 in pharo: ProtoObject>>#~~ cleanup

pharo
Updates:
        Status: FixToInclude

Comment #1 on issue 5763 by [hidden email]: ProtoObject>>#~~ cleanup
http://code.google.com/p/pharo/issues/detail?id=5763

Fix in inbox:  
SLICE-Issue-5763-ProtoObject-double-tilde-cleanup-SeanDeNigris.1

Small refactor, with test


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5763 in pharo: ProtoObject>>#~~ cleanup

pharo

Comment #2 on issue 5763 by marianopeck: ProtoObject>>#~~ cleanup
http://code.google.com/p/pharo/issues/detail?id=5763

Please not the "not"

read: http://forum.world.st/About-and-tp3898409.html


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5763 in pharo: ProtoObject>>#~~ cleanup

pharo
Updates:
        Status: FixReviewNeeded

Comment #3 on issue 5763 by [hidden email]: ProtoObject>>#~~ cleanup
http://code.google.com/p/pharo/issues/detail?id=5763

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5763 in pharo: ProtoObject>>#~~ cleanup

pharo

Comment #4 on issue 5763 by [hidden email]: ProtoObject>>#~~ cleanup
http://code.google.com/p/pharo/issues/detail?id=5763

(status "FixToInclude" means: include without check. Do not Think. Even if  
you have doubt. Is was checked and is good.

So please *never* use "FixToInclude" on something that was not double  
checked or is really really 100% sure that it is good.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5763 in pharo: ProtoObject>>#~~ cleanup

pharo

Comment #5 on issue 5763 by [hidden email]: ProtoObject>>#~~ cleanup
http://code.google.com/p/pharo/issues/detail?id=5763

Thanks Marcus. I selected the wrong status by accident...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5763 in pharo: ProtoObject>>#~~ cleanup

pharo

Comment #6 on issue 5763 by [hidden email]: ProtoObject>>#~~ cleanup
http://code.google.com/p/pharo/issues/detail?id=5763

Take two: SLICE-Issue-5763-ProtoObject-double-tilde-cleanup-SeanDeNigris.2

Reverted to original implementation and put better comments per  
http://forum.world.st/About-and-td3898409.html


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5763 in pharo: ProtoObject>>#~~ cleanup

pharo
Updates:
        Status: FixToInclude

Comment #7 on issue 5763 by marianopeck: ProtoObject>>#~~ cleanup
http://code.google.com/p/pharo/issues/detail?id=5763

Looks fine.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5763 in pharo: ProtoObject>>#~~ cleanup

pharo
Updates:
        Status: Integrated

Comment #8 on issue 5763 by [hidden email]: ProtoObject>>#~~ cleanup
http://code.google.com/p/pharo/issues/detail?id=5763

in 2.0 037


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker