Issue 5772 in pharo: Deprecate FileDirectory

Status: Accepted
Owner: [hidden email]
Labels: Type-Enh

New issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

Do we have to deprecate all methods of the FileDirectory API?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

We should completely remove it and avoid an deprecation step.
FileSystem and the old File stuff don't go along very well, as we tried  
with FileDialog


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

Issue 4658 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

Yay! Goodbye FileDirectory... I will not miss you...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

how do we do this?

- shutting down isolated subparts might work
- do a big one-time migration step and work on fixing the missing methods?

I fear that there are two many FileDirectories floating in the system to  
make it easy to shut down a subpart :/


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #6 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

@camillobruni: Can you give more details please?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

I am also afraid that a lot of people will freak out.

Could we not have stubs like I did with Zn, HTTPSocket, ZnHTTPSocketFacade  
and the Zinc-HTTPSocket package ?

Along the lines of

FileStream class>>fileNamed: fileName do: aBlock
    ^ fileName asReference fileStreamDo: aBlock

And probably many more, even deeper ones.

Or is it only about FileDirectory, not FileStream ?




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

@sven: I don't get your message. We are not planning to remove FileStream  
(yet), only FileDirectory.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

Yeah, I realized at the end that I wasn't paying attention enough.

Anyway, you get the idea. For example, in ZnStaticFileServerDelegate I am  
using FileDirectory.

Yes it is ugly and I am all for a better solution, but I am trying to keep  
Zn working in Pharo 1.3 and 1.4. So some transition technology would be  
nice. And I am just saying that I will not be the only one...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

bah I started a big hackery yesterday and trying to remove everything at  
once...

- FileDirectory reads like a C library, a horror for any ST programmer :/
- People seem to like using strings instead of real Path objects everywhere
- the variable names containing paths are consistently named wrongly  
(fileName vs. filePath)

but yeah, we'll have to add some compat-layer maybe. on the other hand the  
old part is so damn shitty that it doesn't really pay off


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

Yes, the Pharo philosophy is to push forward and be bold, I am not  
suggesting we change that.

But more than 90% of external libraries use FileStream/FileDirectory and  
they will all break at once.

Some minimal compatibility layer convering say 80% of casual use would be  
enough I guess.
Perfect backwards compatibility will be impossible anyway due to subtle  
semantic changes.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

true. so I think I will do two steps here:

1. radically remove all users of FileDirectory possible breaking the system  
here and there (no pain no gain)
2. introduce a minimal backward compatible layer that is entirely  
deprecated (so people are encouraged to migrate their code)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels:  
tionsIssue5683DefaultWorkingDirectory‹Prev15of19Next›1personstarredthisissueandmaybenotifiedofchanges.BacktolistStatus AcceptedOwner ----Milestone-2.0Type-BugAddacommentandmakechangesbelow ReportedbyprojectmembercamillobruniApr252012changetheworkingdirectoryinFileSystemdiskworkingDirectorytotherealworkingdirectoryandnotsimplythepathrelativetotheimage.UsethecodefromOSProcessAddacommentandmakechangesAttachafileSummaryStatusOwner CcLabels AddarowBlocked onNoteYou

Comment #13 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

(No comment was entered for this change.)

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels:  
-tionsIssue5683DefaultWorkingDirectory‹Prev15of19Next›1personstarredthisissueandmaybenotifiedofchanges.BacktolistStatus AcceptedOwner ----Milestone-2.0Type-BugAddacommentandmakechangesbelow ReportedbyprojectmembercamillobruniApr252012changetheworkingdirectoryinFileSystemdiskworkingDirectorytotherealworkingdirectoryandnotsimplythepathrelativetotheimage.UsethecodefromOSProcessAddacommentandmakechangesAttachafileSummaryStatusOwner CcLabels AddarowBlocked onNoteYou  
Filesystem

Comment #14 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

(No comment was entered for this change.)

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #15 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

Slice in inbox

Name: SLICE-Issue-5772-Deprecate-FileDirectory-CamilloBruni.1
Author: CamilloBruni
Time: 23 July 2012, 8:17:38.017 pm
UUID: f9ab0b51-ee14-409a-bb7f-b7e9f800047a
Ancestors:
Dependencies: Tests-CamilloBruni.425, Files-CamilloBruni.ducasse.271,  
ScriptLoader20-CamilloBruni.269

- rewrote the last references to FileDirectory
- removed FileDirectory & Co


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Filesystem FileSystem

Comment #16 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #17 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772#c17

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #18 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #19 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #20 on issue 5772 by [hidden email]: Deprecate FileDirectory
http://code.google.com/p/pharo/issues/detail?id=5772#c20

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker