Issue 5805 in pharo: Failing Test FailingTestResourceTestCase>>#testRunSuiteWithResource

Status: FailingTest
Owner: [hidden email]
CC: [hidden email],  [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 5805 by [hidden email]: Failing Test  
FailingTestResourceTestCase>>#testRunSuiteWithResource
http://code.google.com/p/pharo/issues/detail?id=5805

SUnit.Tests.Core.FailingTestResourceTestCase.testRunSuiteWithResource

Due to integration of Issue 5751


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5805 by [hidden email]: Failing Test  
FailingTestResourceTestCase>>#testRunSuiteWithResource
http://code.google.com/p/pharo/issues/detail?id=5805

It's failing because #signalInitializationError is not implemented and it  
has two senders.
More deeply, the problem is that the test is doing SimpleTestResource  
unavailable, but the suite needs its resources available to run.

The nice things is that that method is not implemented in 1.4 either, and  
since test suite code was dead code It didn't appear before.

What the failing class intends to do:

"Make the resource impossible to make available, then ensure that every  
test raises a failure but not an error (which its setUp would do if it  
reached it and the resource were nil)."


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5805 by [hidden email]: Failing Test  
FailingTestResourceTestCase>>#testRunSuiteWithResource
http://code.google.com/p/pharo/issues/detail?id=5805

This not implemented message is also in 1.2.1.


Now, according to the comment

"Make the resource impossible to make available, then ensure that every  
test raises a failure but not an error (which its setUp would do if it  
reached it and the resource were nil)."

I've tried this implementation

signalInitializationError
    TestFailure signal: ('TestResource: {1} could not be initialized'  
format: { self name asString })

But I do not know if this is right.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5805 by [hidden email]: Failing Test  
FailingTestResourceTestCase>>#testRunSuiteWithResource
http://code.google.com/p/pharo/issues/detail?id=5805

 From squeak 4.2

signalInitializationError
        ^ TestResult signalErrorWith: 'Resource ' , self name , ' could not be  
initialized'

And the testsuite run does kinda the same as ours:
-setup resources
-run testscases
-reset resources

So I'll create an Slice
:)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5805 by [hidden email]: Failing Test  
FailingTestResourceTestCase>>#testRunSuiteWithResource
http://code.google.com/p/pharo/issues/detail?id=5805

Here is the slice.  It add's the lost method only.

Name:  
SLICE-Issue-5805-Failing-Test-FailingTestResourceTestCasegtgttestRunSuiteWithResource--GuillermoPolito.3
Author: GuillermoPolito
Time: 4 May 2012, 9:38:06.666 pm
UUID: 6bd5b01e-aaa1-4a7f-8a71-53577f992667
Ancestors:  
SLICE-Issue-5805-Failing-Test-FailingTestResourceTestCasegtgttestRunSuiteWithResource--GuillermoPolito.1
Dependencies: SUnit-Core-GuillermoPolito.19

commiting the first slice again just to put it on top


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #5 on issue 5805 by [hidden email]: Failing Test  
FailingTestResourceTestCase>>#testRunSuiteWithResource
http://code.google.com/p/pharo/issues/detail?id=5805

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 5805 by [hidden email]: Failing Test  
FailingTestResourceTestCase>>#testRunSuiteWithResource
http://code.google.com/p/pharo/issues/detail?id=5805

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 5805 by [hidden email]: Failing Test  
FailingTestResourceTestCase>>#testRunSuiteWithResource
http://code.google.com/p/pharo/issues/detail?id=5805

in 2.0 050


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker