Issue 5812 in pharo: Add new Chunk format importer

Status: Accepted
Owner: [hidden email]
Labels: Type-Cleanup Difficulty-Easy

New issue 5812 by [hidden email]: Add new Chunk format importer
http://code.google.com/p/pharo/issues/detail?id=5812

I've moved the filein stuff to a new object which:
- is a bit more ordered
- is not inside FileStream
- uses a double dispatch to read methods, class comments...
- uses extension methods so we can uninstall it whenever we want

Slice is coming


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #1 on issue 5812 by [hidden email]: Add new Chunk format  
importer
http://code.google.com/p/pharo/issues/detail?id=5812

Also,
- it has tests :).
- not only exclusive for files.  Serves for any read stream.

Does not handle:
- lang tags (I've never seen them in a fileout)
- styles

BTW, it does not override (yet) FileStream fileIn: '...'.  It's  
independent, thus, safe to include.

Name: SLICE-Issue-5812-Add-new-Chunk-format-importer-GuillermoPolito.1
Author: GuillermoPolito
Time: 5 May 2012, 2:58:29.718 am
UUID: 735cf78f-aacd-466f-b65d-2293b19c3569
Ancestors:
Dependencies: CodeImport-GuillermoPolito.1,  
CodeImport-Tests-GuillermoPolito.1

with tests


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5812 by [hidden email]: Add new Chunk format  
importer
http://code.google.com/p/pharo/issues/detail?id=5812

yes! we sould deprecate old fileIn, then :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #4 on issue 5812 by [hidden email]: Add new Chunk format  
importer
http://code.google.com/p/pharo/issues/detail?id=5812

I'm still polishing some rough corners after Mariano's feedback


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Cc: marianopeck

Comment #5 on issue 5812 by [hidden email]: Add new Chunk format  
importer
http://code.google.com/p/pharo/issues/detail?id=5812

Now it's nicer.

- now the importer is agnostic of the format (which is in the parser).
- separated the loading in two steps: parse and import, so if we just  
parse, we have a bunch of objects to do diffs in changesets and fileins ;).
- Better API

Name: SLICE-Issue-5812-Add-new-Chunk-format-importer-GuillermoPolito.2
Author: GuillermoPolito
Time: 5 May 2012, 5:34:04.418 pm
UUID: d603f265-3495-4f7f-923e-cf000aee9534
Ancestors: SLICE-Issue-5812-Add-new-Chunk-format-importer-GuillermoPolito.1
Dependencies: CodeImport-GuillermoPolito.2,  
CodeImport-Tests-GuillermoPolito.2

-now the importer is agnostic of the format (which is in the parser).  This  
way we can do diffs for changesets :)
- Better API


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #6 on issue 5812 by [hidden email]: Add new Chunk format  
importer
http://code.google.com/p/pharo/issues/detail?id=5812

in 2.0 052


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker