Issue 5815 in pharo: Break dependency between traits and ring

Status: FixReviewNeeded
Owner: marianopeck
CC: [hidden email],  [hidden email],  
[hidden email]
Labels: Type-Bug

New issue 5815 by marianopeck: Break dependency between traits and ring
http://code.google.com/p/pharo/issues/detail?id=5815

For more details read:  
http://forum.world.st/Traits-depending-on-RIng-td4609865.html

Here I propose a change set.

Attachments:
        TraitsCompiledMethod.4.cs  5.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5815 by marianopeck: Break dependency between traits  
and ring
http://code.google.com/p/pharo/issues/detail?id=5815

Ok, here is a better version. It has the same tests results as before the  
change. In addition, it passes all fuel tests regarding traits.

can someone check?

Attachments:
        TraitsCompiledMethod.7.cs  7.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #3 on issue 5815 by [hidden email]: Break dependency  
between traits and ring
http://code.google.com/p/pharo/issues/detail?id=5815

So far, I've seen the code's change and It looks ok.  I've also run the  
traits tests and the kernel tests and It doesn't break anything.

So, it's ok to me.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5815 by [hidden email]: Break dependency  
between traits and ring
http://code.google.com/p/pharo/issues/detail?id=5815

With this fix we can remove Ring from the Kernel image so please integrate  
this together.

Attachments:
        SmalltalkImage-kernelPackageNames.st  1.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5815 by marianopeck: Break dependency between traits  
and ring
http://code.google.com/p/pharo/issues/detail?id=5815

Excellent. Thanks both for doing a look ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #6 on issue 5815 by [hidden email]: Break dependency between  
traits and ring
http://code.google.com/p/pharo/issues/detail?id=5815

in 2.0 052

I removed

System-BreakPoints
System-Debugging

from the kernelPackageNames, too. (as they don't exist anymore)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 5815 by [hidden email]: Break dependency between  
traits and ring
http://code.google.com/p/pharo/issues/detail?id=5815

When I try to integrate that with the normal process I get a stange error,  
maybe we need to load the .cs


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5815 by marianopeck: Break dependency between traits  
and ring
http://code.google.com/p/pharo/issues/detail?id=5815

Marcus: Indeed. I imagined there could be a problem with that and that's  
why I did a .cs instead of a slice.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5815 by [hidden email]: Break dependency between  
traits and ring
http://code.google.com/p/pharo/issues/detail?id=5815

The .cs is In 2.0 053

Next step:
- fix dirty
- integrate the kernlPackageName fix


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 5815 by [hidden email]: Break dependency  
between traits and ring
http://code.google.com/p/pharo/issues/detail?id=5815

in 2.0 055


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 5815 by marianopeck: Break dependency between traits  
and ring
http://code.google.com/p/pharo/issues/detail?id=5815

marcus, what do you mean by "fix dirty" ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5815 by [hidden email]: Break dependency  
between traits and ring
http://code.google.com/p/pharo/issues/detail?id=5815

When loading a .cs the packages are dirty. So you need to save them in the  
repository, and then make
*another* change set to re-load those so that Monticello is in sync.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker