Issue 5818 in pharo: Put back the correct order in #asert:equals:

Status: Accepted
Owner: marianopeck
Labels: Type-Bug

New issue 5818 by marianopeck: Put back the correct order in #asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

So the #assert:equals: is again wwrong.
I will publish the fix.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5818 by [hidden email]: Put back the correct  
order in #asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

Can you check? I switched the expected and actual when integrating and I  
thin it is correct now...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5818 by marianopeck: Put back the correct order in  
#asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

Now

testA
        self assert:  'sss' equals: 42

says:  'Expected 42 but was ''sss''.'

Fix in inbox:

Name:  
SLICE-Issue-5818-Put-back-the-correct-order-in-asertequals-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 5 May 2012, 7:32:13.512 pm
UUID: fce8ee32-077b-480b-9164-d466fcccafdd
Ancestors:
Dependencies: SUnit-Core-MarianoMartinezPeck.22

fix to issue 5818


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5818 by marianopeck: Put back the correct order in  
#asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

Marcus, I tested in latest version and it is the wrong one. We defined (in  
a long discussion in an email) that:

testA
        self assert:  'sss' equals: 42

should say: 'Expected 42 but was ''sss''.'

and it was the other way arround. Wasn't it ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5818 by [hidden email]: Put back the correct  
order in #asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

I always get confused.

We need to add a test first and then change.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5818 by marianopeck: Put back the correct order in  
#asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

Good idea! I will wrote a test. Wiat for it before integrating.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #6 on issue 5818 by marianopeck: Put back the correct order in  
#asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

Done. Marcus, be sure to take the second version of the slice:

Name:  
SLICE-Issue-5818-Put-back-the-correct-order-in-asertequals-MarianoMartinezPeck.2
Author: MarianoMartinezPeck
Time: 5 May 2012, 8:09:58.91 pm
UUID: 7d66e362-0620-4121-b132-ef59420553a3
Ancestors:
Dependencies: SUnit-Tests-MarianoMartinezPeck.3,  
SUnit-Core-MarianoMartinezPeck.23

fix to isue 5818


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #8 on issue 5818 by [hidden email]: Put back the correct  
order in #asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

Tested in 20074. Works


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5818 by [hidden email]: Put back the correct  
order in #asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

But now  we have

assert: actual equals: expected

but

  comparingStringBetween: expected and: actual

I think the whole mess started when someone wanted to fix this  
inconsistency?



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #10 on issue 5818 by [hidden email]: Put back the correct  
order in #asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

I will look at that later


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #11 on issue 5818 by marianopeck: Put back the correct order in  
#asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

Marcus, here is a improved version. I think this is rady to integrate.  
There is even a unit test for it.

SEE THE CORRECT VERSION OF THE SLICE:

Name:  
SLICE-Issue-5818-Put-back-the-correct-order-in-asertequals-MarianoMartinezPeck.3
Author: MarianoMartinezPeck
Time: 22 May 2012, 12:21:51.061 pm
UUID: 9497ce41-acea-47ca-b671-fd083af2ac73
Ancestors:  
SLICE-Issue-5818-Put-back-the-correct-order-in-asertequals-MarianoMartinezPeck.2
Dependencies: SUnit-Tests-MarianoMartinezPeck.3,  
SUnit-Core-MarianoMartinezPeck.24

fox to issue 5818


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #12 on issue 5818 by [hidden email]: Put back the correct  
order in #asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

I will switch the arguments of

comparingStringBetween:and:

to have it consistent


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #13 on issue 5818 by [hidden email]: Put back the correct  
order in #asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

in 2.0 089


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 5818 by marianopeck: Put back the correct order in  
#asert:equals:
http://code.google.com/p/pharo/issues/detail?id=5818

excellent. I made sense :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker