Issue 5821 in pharo: FlatMessageListBrowser broken with class comments

Status: Accepted
Owner: marianopeck
Labels: Type-Bug Milestone-2.0

New issue 5821 by marianopeck: FlatMessageListBrowser broken with class  
comments
http://code.google.com/p/pharo/issues/detail?id=5821

Some time ago added to FlatMessageListBrowser the posibility to also show  
categories:

createColumnsFor: anItem

        ^ bindings
                at: anItem
                ifAbsentPut: [ {anItem realClass name. anItem selector asString, '  
(' ,anItem category asString, ')'} ]


Problem is that the FlatMessageListBrowser is NOT used only for messages  
but also for other things like class comments. My solution right now is to  
make RGCommentDefinition to understand category so that it answers the  
category of its class:

RGCommentDefinition >> category
        ^self realClass category

I will commit this as a workaround.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Cc: [hidden email] [hidden email]

Comment #1 on issue 5821 by marianopeck: FlatMessageListBrowser broken with  
class comments
http://code.google.com/p/pharo/issues/detail?id=5821

Fix in inbox

Name:  
SLICE-Issue-5821-FlatMessageListBrowser-broken-with-class-comments-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 7 May 2012, 12:06:17.722 pm
UUID: 178834af-6dcf-4830-9ea4-2d67034cbfc7
Ancestors:
Dependencies: Ring-Core-Kernel-MarianoMartinezPeck.50

Fix to inbox 5821


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5821 by [hidden email]: FlatMessageListBrowser  
broken with class comments
http://code.google.com/p/pharo/issues/detail?id=5821

Hi guys,

I do not like this, the stuff that I killed from the references classes is  
being introduced again.
The idea is not to have RGCommentDefinition and RGMethodDefinition  
understanding the same methods.
So I will work a bit on Ring this weekend to clean what shouldn't be  
introduced and fix this bug as well.
Moreover I see that the API that I marked as "removed soon" (eg. selector  
in comment) or backwards compatibility (eg. category) is being referenced  
instead of the clean Ring's API.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5821 by marianopeck: FlatMessageListBrowser broken with  
class comments
http://code.google.com/p/pharo/issues/detail?id=5821

Hi Veronica. I don't like it either, I just wanted to quickly fix the  
broken current behavior. However, I doubt that it is Ring's problem. I  
think it is about the tool (FlatMessagesList in this case). See my email:  
http://forum.world.st/FlatMessageListBrowser-and-class-comments-td4614465.html


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5821 by [hidden email]: FlatMessageListBrowser  
broken with class comments
http://code.google.com/p/pharo/issues/detail?id=5821

This tool will be changed soon (at least in 2.0) :)




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Duplicate
        Mergedinto: 5832

Comment #5 on issue 5821 by [hidden email]: FlatMessageListBrowser  
broken with class comments
http://code.google.com/p/pharo/issues/detail?id=5821

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Mergedinto:

Comment #6 on issue 5821 by [hidden email]: FlatMessageListBrowser  
broken with class comments
http://code.google.com/p/pharo/issues/detail?id=5821

Now that FlatMessageListBrowser is magically back we need this


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 5821 by [hidden email]: FlatMessageListBrowser  
broken with class comments
http://code.google.com/p/pharo/issues/detail?id=5821

in 2.0 065


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker