Issue 5833 in pharo: More robust allSuperclassesIncluding:

Status: New
Owner: ----
Labels: Type-Bug

New issue 5833 by [hidden email]: More robust  
allSuperclassesIncluding:
http://code.google.com/p/pharo/issues/detail?id=5833

allSuperclassesIncluding: aClass
        "Answer an OrderedCollection of the receiver's and the receiver's
        ancestor's superclasses up to aClass included."
        | temp |
        self class == ProtoObject class ifTrue: [ ^ OrderedCollection new].
        ^ superclass == aClass
                ifTrue: [ OrderedCollection with: aClass]
                ifFalse: [temp := superclass allSuperclassesIncluding: aClass.
                        temp addFirst: superclass.
                        temp]


Indeed we got a bug if aClass was not in the hierarchy of the receiver  
(this happens when UndefinedObject class was used resulting from some bugs  
in Glamour).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5833 by [hidden email]: More robust  
allSuperclassesIncluding:
http://code.google.com/p/pharo/issues/detail?id=5833

stef did it with usman


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Labels: Milestone-1.4 Milestone-2.0

Comment #2 on issue 5833 by [hidden email]: More robust  
allSuperclassesIncluding:
http://code.google.com/p/pharo/issues/detail?id=5833

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #3 on issue 5833 by [hidden email]: More robust  
allSuperclassesIncluding:
http://code.google.com/p/pharo/issues/detail?id=5833

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5833 by [hidden email]: More robust  
allSuperclassesIncluding:
http://code.google.com/p/pharo/issues/detail?id=5833

allSuperclassesIncluding: aClass
        "Answer an OrderedCollection of the receiver's and the receiver's
        ancestor's superclasses up to aClass included. If aClass is not part of  
the receiver's superclass, returns up to the root."
        | temp |
        self class == ProtoObject class ifTrue: [ ^ OrderedCollection new].
        ^ superclass == aClass
                ifTrue: [ OrderedCollection with: aClass]
                ifFalse: [temp := superclass allSuperclassesIncluding: aClass.
                        temp addFirst: superclass.
                        temp]


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.4

Comment #5 on issue 5833 by [hidden email]: More robust  
allSuperclassesIncluding:
http://code.google.com/p/pharo/issues/detail?id=5833

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.4

Comment #6 on issue 5833 by [hidden email]: More robust  
allSuperclassesIncluding:
http://code.google.com/p/pharo/issues/detail?id=5833

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #7 on issue 5833 by [hidden email]: More robust  
allSuperclassesIncluding:
http://code.google.com/p/pharo/issues/detail?id=5833

code needed


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #8 on issue 5833 by [hidden email]: More robust  
allSuperclassesIncluding:
http://code.google.com/p/pharo/issues/detail?id=5833

(No comment was entered for this change.)

Attachments:
        AllSuperClassesIncluding.1.cs  663 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-2.0

Comment #9 on issue 5833 by [hidden email]: More robust  
allSuperclassesIncluding:
http://code.google.com/p/pharo/issues/detail?id=5833

in 2.0 072

TODO: 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 5833 by [hidden email]: More robust  
allSuperclassesIncluding:
http://code.google.com/p/pharo/issues/detail?id=5833

in 1.4 443


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker