Issue 5839 in pharo: TestRunner Run Coverage fails.

Status: New
Owner: ----
Labels: Type-Bug

New issue 5839 by [hidden email]: TestRunner Run Coverage fails.
http://code.google.com/p/pharo/issues/detail?id=5839


Pharo2.0a
Latest update: #20057
CogVM version 3.9-7 (Mar 28th) on amd64 Ubuntu 12.04

Issue: When using TestRunner, Run Coverage fails.
TestRunner>>collectCoverageFor: methods
in the wrappers isEmpty ifFalse: block, "Smalltalk tools messageList"  
answers MessageListBrowser, but only FlatMessageListBrowser implements the  
on:named: constructor used here.

I worked around this by:
Smalltalk tools inspect.

then in the inspector
tools at: #messageList put: FlatMessageListBrowser.

after which the TestRunner coverage reports worked fine.

Not sure if the system dictionary should be updated, or if TestRunner needs  
another mechanism to find the MessageListBrowser, or if MessageListBrowser  
should support the on:named: constructor.

Thanks,

Dan Uber
[hidden email]


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5839 by [hidden email]: TestRunner Run Coverage fails.
http://code.google.com/p/pharo/issues/detail?id=5839

In Pharo-1.4: Smalltalk tools messageList answers FlatMessageListBrowser.
In Pharo-2.0: it answers MessageListBrowser.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded
        Cc: [hidden email]
        Labels: Milestone-2.0

Comment #2 on issue 5839 by [hidden email]: TestRunner Run Coverage  
fails.
http://code.google.com/p/pharo/issues/detail?id=5839

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5839 by [hidden email]: TestRunner Run Coverage  
fails.
http://code.google.com/p/pharo/issues/detail?id=5839

FlatMessageListBrowser will be removed soon.... so we need to change the  
TestRunner to use it (or MessageListBrowser to implement #on:named:)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5839 by [hidden email]: TestRunner Run Coverage  
fails.
http://code.google.com/p/pharo/issues/detail?id=5839

FlatMessageListBrowser will be removed soon.... so we need to change the  
TestRunner to use it (or MessageListBrowser to implement #on:named:)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5839 by [hidden email]: TestRunner Run Coverage fails.
http://code.google.com/p/pharo/issues/detail?id=5839

Update 20069 removes FlatMessageListBrowser from the system.

TestRunner Run Coverage now generates a DNU error for MessageBrowser  
#on:named:

Should Smalltalk tools messageList return MessageBrowser (current as of  
20069) or MessageListBrowser (previous behavior a few days ago)?



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5839 by [hidden email]: TestRunner Run Coverage fails.
http://code.google.com/p/pharo/issues/detail?id=5839

I added a slice for this to PharoInbox. I'm not sure that this is the right  
way to do it. If there is a better contribution process, I'd be happy to  
redo it.

added on:named: and open to MessageBrowser (in the most naive way possible)
added collect: and do: to MessageList. (just passing through to  
messageReferenceList)

Attachments:
        SLICE-Issue-5839-TestRunner-Run-Coverage-fails-DanielUber.1.mcz  16.8 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 5839 by [hidden email]: TestRunner Run Coverage  
fails.
http://code.google.com/p/pharo/issues/detail?id=5839

I just posted a new version of Spec-Tools which add the method  
MessageBrowser class>>#on:named:

Spec-Tools-BenjaminVanRyseghem.23 in PharoInbox.

@djuber: why do you add collect and do on MessageList ?
And I do not understand why you provide a MessageList for the  
MessageBrowser and not a list of messages.

Could you please check my change and confirm ? (I quickly checked but I do  
not know how coverage works so maybe I missed something :) )


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5839 by [hidden email]: TestRunner Run Coverage fails.
http://code.google.com/p/pharo/issues/detail?id=5839

Benjamin,

thank you, I tested your Spec-Tools package from PharoInbox on a fresh  
image and it does correct the issue.

It appears the MessageList methods were unused. The debugger did give me  
a 'does not understand' for these two (collect and do), but that may have  
been a quirk, and looks like it doesn't happen now.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #9 on issue 5839 by [hidden email]: TestRunner Run Coverage  
fails.
http://code.google.com/p/pharo/issues/detail?id=5839

in 2.0 073


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker