Issue 5873 in pharo: [BUG]: ZipArchive does not correctly zip hierarchies

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug

New issue 5873 by [hidden email]: [BUG]: ZipArchive does not  
correctly zip hierarchies
http://code.google.com/p/pharo/issues/detail?id=5873

Pharo2.0a
Latest update: #20071

1. DoIt script below
2. Try to unzip from underlying OS (tested on OS X 10.7)

I get a dialog "Unable to expand "_test-zip-dir" into "[parent folder  
name]". (Error 1 - Operation not permitted/)

Zipping files and empty folders works, but not folders with files in them

"Adapted from ZipArchiveTest>>testCreateWithRelativeNames..."

        | subdir zip |
        subdir := FileDirectory default / '_test-zip-dir'.
        subdir assureExistence.
        subdir
                fileNamed: '_test-zip-file'
                do: [ : stream | stream nextPutAll: 'file contents' ].
        zip := ZipArchive new.
        zip
                addDirectory: subdir fullName
                as: subdir localName.
        zip
                addFile: (subdir fullNameFor: '_test-zip-file')
                as: '_test-zip-dir' , FileDirectory slash , '_test-zip-file'.
        zip writeToFileNamed: (FileDirectory default fullNameFor: '_test.zip').
        zip close.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5873 by [hidden email]: [BUG]: ZipArchive does  
not correctly zip hierarchies
http://code.google.com/p/pharo/issues/detail?id=5873

Fix in inbox: Name:  
SLICE-Issue-5873-BUG-ZipArchive-does-not-correctly-zip-hierarchies-SeanDeNigris.1

* Fix file attributes. This is the source of the bug where nested  
hierarchies led to corrupt zip files; directories did not have the file  
type set to directory
* Fix zip date and time reading/writing
* Tests: cleaned and added; all pass
* Documentation: added links to zip reference sources; method comments

TODO:
* there is still a lot of cleaning to be done, but this funtionality is  
good enough to commit
* I think the time and date zipping/unzipping should be moved into the dos  
conversion methods in Date/Time, but I'll save that for another issue


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-2.0

Comment #2 on issue 5873 by [hidden email]: [BUG]: ZipArchive does  
not correctly zip hierarchies
http://code.google.com/p/pharo/issues/detail?id=5873

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5873 by [hidden email]: [BUG]: ZipArchive does  
not correctly zip hierarchies
http://code.google.com/p/pharo/issues/detail?id=5873

sean when I merge your changes in 20117 I got two conflicts.
I checked if i take your changes for the con flits of not I get red tests.

I will try to have a look. (too bad that we let the code rot).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5873 by [hidden email]: [BUG]: ZipArchive  
does not correctly zip hierarchies
http://code.google.com/p/pharo/issues/detail?id=5873

Ok, we should provide tests for unzipping too I think :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #5 on issue 5873 by [hidden email]: [BUG]: ZipArchive  
does not correctly zip hierarchies
http://code.google.com/p/pharo/issues/detail?id=5873

Ok, tests are in the slice :).

To my non-zip expertise, the changes look ok. Tests are added, nice  
comments with zip spec, and flags where some extra review is needed in the  
future.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #6 on issue 5873 by [hidden email]: [BUG]: ZipArchive does  
not correctly zip hierarchies
http://code.google.com/p/pharo/issues/detail?id=5873

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker