Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
26 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Enh

New issue 5874 by [hidden email]: [ENH]: Notify progress with  
Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

Pharo2.0a
Latest update: #20071

This seems like a natural use case for Announcements and Exceptions seems  
like more of a hack.

I found the Exception behavior very hard to customize. I caught the  
ProgressInitiationException, but the ProgressNotification exceptions seemed  
to be caught elsewhere and I could not get to them


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo

Comment #1 on issue 5874 by [hidden email]: [ENH]: Notify progress with  
Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

yes. An exception-based way is too complicated.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo

Comment #2 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

A few updates...
* String>>displayProgressAt:from:to:during: has "deprecated" in the  
comment, but is not in a deprecated category. The timestamp is 9/7/11 which  
puts it either 1.2 or early 1.3, but either way, it should be removed for  
2.0, right? There is only one sender in the image, which can easily be  
fixed to call #displayProgressFrom:to:during:
* String>>displayProgressFrom:to:during: should probably delegate to the  
UIManager's displayProgress:from:to:during:
* Progress should have its own announcer. The progress could be something  
that doesn't alter the system, so it doesn't really fit into system  
announcer.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo

Comment #3 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

while you are there, could you take a look at issue 5550?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
In reply to this post by pharo
Issue 5874: [ENH]: Notify progress with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

This issue is now blocking issue 5550.
See http://code.google.com/p/pharo/issues/detail?id=5550

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
In reply to this post by pharo

Comment #5 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

Name:  
SLICE-Issue-5874-ENH-Notify-progress-with-Announcements-instead-of-Exceptions-CamilloBruni.3
Author: CamilloBruni
Time: 1 September 2012, 8:43:33.801 pm
UUID: 8981c840-2f83-4b96-bdcf-800b1f3bbd2c
Ancestors:  
SLICE-Issue-5874-ENH-Notify-progress-with-Announcements-instead-of-Exceptions-SeanDeNigris.2
Dependencies: UIManager-CamilloBruni.78, Deprecated20-CamilloBruni.22,  
Polymorph-Widgets-CamilloBruni.698, Kernel-CamilloBruni.1187,  
Morphic-CamilloBruni.1229, KernelTests-CamilloBruni.445,  
Tools-CamilloBruni.921

- refactored and cleaned up Job implementation
- added hierarchy for job notifications
- added basic use-case tests
- added two basic examples


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
In reply to this post by pharo
Issue 5874: [ENH]: Notify progress with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

This issue is now blocking issue pharo:5550.
See http://code.google.com/p/pharo/issues/detail?id=5550

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
In reply to this post by pharo
Issue 5874: [ENH]: Notify progress with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

This issue is now blocking issue pharo:5550.
See http://code.google.com/p/pharo/issues/detail?id=5550

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
In reply to this post by pharo
Updates:
        Status: FixReviewNeeded

Comment #7 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
Updates:
        Labels: Milestone-2.0

Comment #8 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
Updates:
        Status: MonkeyIsChecking

Comment #9 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874#c9

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
Updates:
        Status: HumanReviewNeeded

Comment #10 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
Updates:
        Status: FixReviewNeeded

Comment #11 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
Updates:
        Status: MonkeyIsChecking

Comment #12 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874#c12

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
Updates:
        Status: HumanReviewNeeded

Comment #13 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

This one needs special care when integrating as the whole updating/progress  
mechanism is changed the progress bar is most probably going to break  
during the update.

- disable progress bar / or catch+mute all progress notifications
- integrate issue
- activate progress notifications again


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
Updates:
        Status: FixReviewNeeded

Comment #14 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

made version which does not delete stuff, so it should load properly

Name:  
SLICE-Issue-5874-ENH-Notify-progress-with-Announcements-instead-of-Exceptions-CamilloBruni.7
Author: CamilloBruni
Time: 5 October 2012, 5:10:06.019 pm
UUID: d988b875-b54f-4f80-b50b-51099e982c44
Ancestors:  
SLICE-Issue-5874-ENH-Notify-progress-with-Announcements-instead-of-Exceptions-CamilloBruni.6
Dependencies: UIManager-CamilloBruni.79, Deprecated20-CamilloBruni.22,  
Polymorph-Widgets-CamilloBruni.700, Kernel-CamilloBruni.1211,  
Morphic-CamilloBruni.1249, KernelTests-CamilloBruni.446,  
Tools-CamilloBruni.933

don't inform and use better icon


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
Updates:
        Status: MonkeyIsChecking

Comment #15 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874#c15

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
Updates:
        Status: HumanReviewNeeded

Comment #16 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
Updates:
        Status: FixToInclude

Comment #17 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5874 in pharo: [ENH]: Notify progress with Announcements instead of Exceptions

pharo
Updates:
        Status: WorkNeeded

Comment #18 on issue 5874 by [hidden email]: [ENH]: Notify progress  
with Announcements instead of Exceptions
http://code.google.com/p/pharo/issues/detail?id=5874

On merge i get: "Error: can not remove non-empty category"


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
12