Issue 5878 in pharo: Monticello history search

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5878 in pharo: Monticello history search

pharo
Status: FixReviewNeeded
Owner: [hidden email]
Labels: Type-Bug

New issue 5878 by [hidden email]: Monticello history search
http://code.google.com/p/pharo/issues/detail?id=5878

Name: Monticello-eem.505
Author: eem
Time: 26 April 2012, 9:41:06.528 am
UUID: 343bf518-4d54-4622-a5ff-4a6c299ddfd2
Ancestors: Monticello-bf.504

Simple history search for the working copy browser.
Open a Workspace containing all the history (version
summaries) for the current package.

=============== Diff against Monticello-bf.504 ===============

Item was added:
+ ----- Method: MCWorkingCopyBrowser>>searchHistory (in category 'actions')  
-----
+ searchHistory
+       workingCopy ifNotNil:
+               [(UIManager default
+                       edit: (String streamContents:
+                                       [:s|
+                                       "Ignore the initial  
MCWorkingAncestry instance."
+                                       workingCopy ancestry  
topologicalAncestors allButFirst
+                                               do: [:versionInfo|
+                                                       s nextPutAll:  
versionInfo summary]
+                                               separatedBy: [s cr; cr";  
next: 32 put: $-; cr; cr"]])
+                       label: 'Version History: ',  workingCopy  
packageName)
+                               extent: (0.6@1) * Display height * 0.9]!

Item was changed:
  ----- Method: MCWorkingCopyBrowser>>workingCopyListMenu: (in  
category 'morphic ui') -----
  workingCopyListMenu: aMenu
        workingCopy ifNil: [^ aMenu].
        self fillMenu: aMenu fromSpecs:
                #(('add required package' #addRequiredPackage)
                        ('clear required packages' #clearRequiredPackages)
                        ('add repository...' #addPackageRepository)
                        ('browse package' #browseWorkingCopy)
                        ('view changes' #viewChanges)
                        ('view history' #viewHistory)
+                       ('search history' #searchHistory)
                        ('recompile package' #recompilePackage)
                        ('revert package...' #revertPackage)
                        ('unload package' #unloadPackage)
                        ('delete working copy' #deleteWorkingCopy)
                        ('rename package...' #renamePackage)).
        (Smalltalk includesKey: #SARMCPackageDumper) ifTrue: [
                aMenu add: 'make SAR' target: self selector: #fileOutAsSAR
        ].
        self insertExternalMenuEntries: aMenu.
        ^aMenu!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5878 in pharo: Monticello history search

pharo
Updates:
        Status: Workneeded

Comment #1 on issue 5878 by [hidden email]: Monticello history search
http://code.google.com/p/pharo/issues/detail?id=5878

No machine readable code --> Work needed


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5878 in pharo: Monticello history search

pharo
Updates:
        Status: WorkNeeded

Comment #2 on issue 5878 by [hidden email]: Monticello history search
http://code.google.com/p/pharo/issues/detail?id=5878

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5878 in pharo: Monticello history search

pharo

Comment #3 on issue 5878 by [hidden email]: Monticello history search
http://code.google.com/p/pharo/issues/detail?id=5878

the name is definitely misleading, searchHistory does not search but only  
display.
I vote for close, we rather need a search feature in the history browser...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5878 in pharo: Monticello history search

pharo
Updates:
        Labels: Squeak

Comment #4 on issue 5878 by [hidden email]: Monticello history search
http://code.google.com/p/pharo/issues/detail?id=5878

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5878 in pharo: Monticello history search

pharo
Updates:
        Labels: sprintchile

Comment #5 on issue 5878 by [hidden email]: Monticello history search
http://code.google.com/p/pharo/issues/detail?id=5878

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5878 in pharo: Monticello history search

pharo

Comment #6 on issue 5878 by [hidden email]: Monticello history  
search
http://code.google.com/p/pharo/issues/detail?id=5878

We created the method and changed its name for: viewPastComments. Created a  
SLICE.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5878 in pharo: Monticello history search

pharo
Updates:
        Status: FixToInclude

Comment #7 on issue 5878 by [hidden email]: Monticello history search
http://code.google.com/p/pharo/issues/detail?id=5878

This is a small but useful improvement of the monticello browser. Worth  
including in my opinion.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5878 in pharo: Monticello history search

pharo
In reply to this post by pharo
Updates:
        Labels: -Milestone-1.4 Milestone-2.0

Comment #9 on issue 5878 by [hidden email]: Monticello history search
http://code.google.com/p/pharo/issues/detail?id=5878

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5878 in pharo: Monticello history search

pharo
Updates:
        Status: Integrated

Comment #10 on issue 5878 by [hidden email]: Monticello history  
search
http://code.google.com/p/pharo/issues/detail?id=5878

in 2.0 501


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker