Issue 5897 in pharo: [ENH]: Clean SystemProgressMorph and friends

Status: Accepted
Owner: [hidden email]
Labels: Type-Cleanup

New issue 5897 by [hidden email]: [ENH]: Clean SystemProgressMorph  
and friends
http://code.google.com/p/pharo/issues/detail?id=5897

Pharo2.0a
Latest update: #20074

As a first step for "Issue 5874: [ENH]: Notify progress with Announcements  
instead of Exceptions", clean SystemProgressMorph & SystemProgressBarMorph


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5897 by [hidden email]: [ENH]: Clean  
SystemProgressMorph and friends
http://code.google.com/p/pharo/issues/detail?id=5897

Issue 5897: [ENH]: Clean SystemProgressMorph and friends
Fix in inbox:  
SLICE-Issue-5897-ENH-Clean-SystemProgressMorph-and-friends-SeanDeNigris.1

* create NewSystemProgressMorph as a replacement for SystemProgressMorph
* create SystemProgressItemMorph to capture all the behavior from the huge  
block in SystemProgressMorph>>label:min:max:
* Rename SystemProgressBarMorph to ProgressBarMorph (there's nothing  
System-specific) and clean

I'd like someone to review the code, especially the process/semaphore parts  
of NewSystemProgressMorph before I integrate these classes with the system  
via the UIManagers.

I had to do "Compiler recompileAll" when I filed the classes in because the  
system was confused between SystemProgressBarMorph and ProgressBarMorph.  
I'm not sure why.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #2 on issue 5897 by [hidden email]: [ENH]: Clean  
SystemProgressMorph and friends
http://code.google.com/p/pharo/issues/detail?id=5897

to me it looks ok and we can integrate it


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5897 by [hidden email]: [ENH]: Clean  
SystemProgressMorph and friends
http://code.google.com/p/pharo/issues/detail?id=5897

in 20080


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #4 on issue 5897 by [hidden email]: [ENH]: Clean  
SystemProgressMorph and friends
http://code.google.com/p/pharo/issues/detail?id=5897

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker