Issue 5903 in pharo: MonticelloAnnouncer may announce two times an announcement

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5903 in pharo: MonticelloAnnouncer may announce two times an announcement

pharo
Status: FixToReview
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 5903 by [hidden email]: MonticelloAnnouncer may announce  
two times an announcement
http://code.google.com/p/pharo/issues/detail?id=5903

new
        | instance |
        instance := super new.
        MonticelloAnnouncer announcer announce: (MCWorkingCopyCreated workingCopy:  
instance).
        ^ instance

forPackage: aPackage
        ^ self registry at: aPackage ifAbsent:
                [|mgr|
                mgr := self new initializeWithPackage: aPackage.
                                 ^^^^^^
                self registry at: aPackage put: mgr.
                self changed: (Array with: #registered with: aPackage).
                MonticelloAnnouncer announcer announce: (MCWorkingCopyCreated  
workingCopy: mgr package: aPackage).
                mgr]


So removing new may be a solution. Now this is not clear that there is no  
direct new senders.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5903 in pharo: MonticelloAnnouncer may announce two times an announcement

pharo
Updates:
        Status: FixToInclude

Comment #2 on issue 5903 by [hidden email]: MonticelloAnnouncer may  
announce two times an announcement
http://code.google.com/p/pharo/issues/detail?id=5903

Slice published.

- fixng MonticelloAnnouncer may announce two times an announcement
- Fixing also refactoring extract method when the method already exist


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5903 in pharo: MonticelloAnnouncer may announce two times an announcement

pharo

Comment #3 on issue 5903 by [hidden email]: MonticelloAnnouncer may  
announce two times an announcement
http://code.google.com/p/pharo/issues/detail?id=5903

in 20078


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5903 in pharo: MonticelloAnnouncer may announce two times an announcement

pharo
Updates:
        Status: Integrated

Comment #4 on issue 5903 by [hidden email]: MonticelloAnnouncer may  
announce two times an announcement
http://code.google.com/p/pharo/issues/detail?id=5903

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5903 in pharo: MonticelloAnnouncer may announce two times an announcement

pharo
Updates:
        Status: FixToInclude

Comment #5 on issue 5903 by [hidden email]: MonticelloAnnouncer may  
announce two times an announcement
http://code.google.com/p/pharo/issues/detail?id=5903

Apparently it was not in 20078


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5903 in pharo: MonticelloAnnouncer may announce two times an announcement

pharo

Comment #6 on issue 5903 by [hidden email]: MonticelloAnnouncer may  
announce two times an announcement
http://code.google.com/p/pharo/issues/detail?id=5903

retried to merge it in 20084


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5903 in pharo: MonticelloAnnouncer may announce two times an announcement

pharo
Updates:
        Status: Integrated

Comment #7 on issue 5903 by [hidden email]: MonticelloAnnouncer may  
announce two times an announcement
http://code.google.com/p/pharo/issues/detail?id=5903

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker