Issue 5910 in pharo: [Cleanup]: Gut DateAndTimeDosEpochTests

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5910 in pharo: [Cleanup]: Gut DateAndTimeDosEpochTests

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Cleanup Milestone-2.0

New issue 5910 by [hidden email]: [Cleanup]: Gut  
DateAndTimeDosEpochTests
http://code.google.com/p/pharo/issues/detail?id=5910

Pharo2.0a
Latest update: #20075

This test class is useless. It creates an instance of "DateAndTime  
dosEpoch" and then runs it through the entire DateAndTime api. A simple  
check against the date string will suffice.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5910 in pharo: [Cleanup]: Gut DateAndTimeDosEpochTests

pharo
Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5910 by [hidden email]: [Cleanup]: Gut  
DateAndTimeDosEpochTests
http://code.google.com/p/pharo/issues/detail?id=5910

Fix in inbox: Name:  
SLICE-Issue-5910-Cleanup-Gut-DateAndTimeDosEpochTests-SeanDeNigris.1

* Remove DateAndTimeDosEpochTests, which is useless. It creates an instance  
of "DateAndTime dosEpoch" and then runs it through the entire DateAndTime  
api.

* Replace above with DateAndTimeTest >>#testDosEpoch


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5910 in pharo: [Cleanup]: Gut DateAndTimeDosEpochTests

pharo
Updates:
        Status: Workneeded

Comment #2 on issue 5910 by [hidden email]: [Cleanup]: Gut  
DateAndTimeDosEpochTests
http://code.google.com/p/pharo/issues/detail?id=5910

Don't integrate yet. I'm going to kill DateAndTimeEpochTests &  
DateAndTimeUnixEpochTests also, but I'm waiting on a piece of info  
(http://forum.world.st/Epoch-returns-local-offset-td4630549.html)...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5910 in pharo: [Cleanup]: Gut DateAndTimeDosEpochTests

pharo

Comment #3 on issue 5910 by [hidden email]: [Cleanup]: Gut  
DateAndTimeDosEpochTests
http://code.google.com/p/pharo/issues/detail?id=5910

Looks like DateAndTimeLeapTest falls into this same category


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5910 in pharo: [Cleanup]: Gut DateAndTimeDosEpochTests

pharo
Updates:
        Blockedon: 5913

Comment #4 on issue 5910 by [hidden email]: [Cleanup]: Gut  
DateAndTimeDosEpochTests
http://code.google.com/p/pharo/issues/detail?id=5910

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5910 in pharo: [Cleanup]: Gut DateAndTimeDosEpochTests

pharo
In reply to this post by pharo
Updates:
        Labels: -Milestone-2.0 Milestone-3.0

Comment #6 on issue 5910 by [hidden email]: [Cleanup]: Gut  
DateAndTimeDosEpochTests
http://code.google.com/p/pharo/issues/detail?id=5910

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker