Issue 5914 in pharo: Object>>notYetImplemented currently impractical for TDD, uses #inform: which does not fail the tests.

Status: New
Owner: ----
Labels: Milestone-2.0 Type-Feature Difficulty-Easy

New issue 5914 by [hidden email]: Object>>notYetImplemented currently  
impractical for TDD, uses #inform: which does not fail the tests.
http://code.google.com/p/pharo/issues/detail?id=5914

Could Object>>notYetImplemented be changed to for instance use #error:  
instead of #inform:?
Currently, I just get bunches for dialog windows instead of properly  
failing tests when using `self notYetImplemented`

Attachments:
        Object-notYetImplemented.st  257 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5914 by [hidden email]:  
Object>>notYetImplemented currently impractical for TDD, uses #inform:  
which does not fail the tests.
http://code.google.com/p/pharo/issues/detail?id=5914

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5914 by [hidden email]:  
Object>>notYetImplemented currently impractical for TDD, uses #inform:  
which does not fail the tests.
http://code.google.com/p/pharo/issues/detail?id=5914

yes, all the other methods use exceptions that are subclasses of  
SelectorException (which is an Error).

maybe we should do that here, too, so it is the same as ShouldBeImplemented.

The question than is: would just having #shouldBeImplemented be enough? do  
we need #notYetImplemented in addition?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5914 by [hidden email]: Object>>notYetImplemented  
currently impractical for TDD, uses #inform: which does not fail the tests.
http://code.google.com/p/pharo/issues/detail?id=5914

+1 to use exception
-1 to boil down it to use shouldBeImplemented.

because shouldBeImplemented used to indicate abstract method in class ,  
while
notYetImplemented indicates a missing feature which belongs to that class,  
but as it says, not yet implemented


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5914 by [hidden email]: Object>>notYetImplemented  
currently impractical for TDD, uses #inform: which does not fail the tests.
http://code.google.com/p/pharo/issues/detail?id=5914

ah.. sorry.. i stand corrected.. for abstract it uses  
#subclassResponsibility

so.. shouldBeImplemented is a synonym of notYetImplemented

like that i think we can implement

notYetImplemented
   ^ self shouldBeImplemented

over :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5914 by [hidden email]: Object>>notYetImplemented  
currently impractical for TDD, uses #inform: which does not fail the tests.
http://code.google.com/p/pharo/issues/detail?id=5914

I didn't know about the ShouldBeImplemented error class.

notYetImplemented
   ^ self shouldBeImplemented

sounds like a good solution to me.

Thanks


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5914 by [hidden email]: Object>>notYetImplemented  
currently impractical for TDD, uses #inform: which does not fail the tests.
http://code.google.com/p/pharo/issues/detail?id=5914

right, with one correction that since #shouldBeImplemented uses sender  
context,
we should copy/paste it's implementation, instead of sending the message.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5914 by [hidden email]:  
Object>>notYetImplemented currently impractical for TDD, uses #inform:  
which does not fail the tests.
http://code.google.com/p/pharo/issues/detail?id=5914

The attached cs implements it exactly like #shouldBeImplemented, even with  
it's own error... (not sure about that, but it looks cleaner)

Attachments:
        NotYetImplemented.1.cs  6.9 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #8 on issue 5914 by [hidden email]:  
Object>>notYetImplemented currently impractical for TDD, uses #inform:  
which does not fail the tests.
http://code.google.com/p/pharo/issues/detail?id=5914

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #9 on issue 5914 by [hidden email]:  
Object>>notYetImplemented currently impractical for TDD, uses #inform:  
which does not fail the tests.
http://code.google.com/p/pharo/issues/detail?id=5914

in 2.0 097


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker