Issue 5928 in pharo: SystemNavigationTest>>setup looks strange

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 5928 by [hidden email]: SystemNavigationTest>>setup looks  
strange
http://code.google.com/p/pharo/issues/detail?id=5928

I do not understand why SystemNavigation has anything to do with the  
privateAnnouncer of SystemAnnouncer.

setUp
        super setUp.
       
        oldMonticelloAnnouncer := SystemAnnouncer privateAnnouncer.
        SystemAnnouncer instVarNamed: 'privateAnnouncer' put: nil.
       
        navigator := self createSystemNavigationToTest.
        classFactory := self createClassFactory.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5928 by [hidden email]:  
SystemNavigationTest>>setup looks strange
http://code.google.com/p/pharo/issues/detail?id=5928

May be this is linked to the fact that RPackageOrganizer exposes the  
private announcer of SystemAnnouncer
as follow:

RPackageOrganizer>>announcer

        ^ SystemAnnouncer privateAnnouncer


RPackageOrganizer>>registerPackage: aPackage
        "A new package is now available and declared in the receiver. "
       
       
        self basicRegisterPackage: aPackage.
        aPackage extendedClasses do: [ :extendedClass|
                        self registerExtendingPackage: aPackage forClass: extendedClass].
        aPackage definedClasses do: [ :definedClass|
                        self registerPackage: aPackage forClass: definedClass].
        self announcer announce: (RPackageCreated to: aPackage).
        ^ aPackage


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5928 by [hidden email]:  
SystemNavigationTest>>setup looks strange
http://code.google.com/p/pharo/issues/detail?id=5928

Oops the teardown is quite strange

SystemNavigationTest>>setUp
        super setUp.
       
        oldMonticelloAnnouncer := SystemAnnouncer privateAnnouncer.
        SystemAnnouncer instVarNamed: 'privateAnnouncer' put: nil.
       
        navigator := self createSystemNavigationToTest.
        classFactory := self createClassFactory.


SystemNavigationTest>>tearDown
        super tearDown.
        self classFactory cleanUp.
        MonticelloAnnouncer instVarNamed: 'privateAnnouncer' put:  
oldMonticelloAnnouncer.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5928 by [hidden email]:  
SystemNavigationTest>>setup looks strange
http://code.google.com/p/pharo/issues/detail?id=5928

so the change is probably due to the not working behavior of  
compileSilently: but to me it looks that there is a problem.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5928 by [hidden email]:  
SystemNavigationTest>>setup looks strange
http://code.google.com/p/pharo/issues/detail?id=5928

Yeap, that actually does not fix the real problem.  It is just patching the  
fact that the test is not silent, and made lots of debuggers open because  
nobody expected announcements from the tests classes :).

But yes, the SystemAnnouncer vs Monticello announcers seems to be a mistake  
I made -> Checking


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5928 by [hidden email]:  
SystemNavigationTest>>setup looks strange
http://code.google.com/p/pharo/issues/detail?id=5928

Changing in the tearDown MonticelloAnnouncer by SystemAnnouncer tests are  
still green.

But maybe it's time to attack the real problem and make the tests silent :).

So, Rpackage guys, what do you recommend?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #6 on issue 5928 by [hidden email]:  
SystemNavigationTest>>setup looks strange
http://code.google.com/p/pharo/issues/detail?id=5928

in  
SLICE-Issue-5928-SystemNavigationTestgtgtsetup-looks-strange-EstebanLorenzano.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Duplicate

Comment #7 on issue 5928 by [hidden email]:  
SystemNavigationTest>>setup looks strange
http://code.google.com/p/pharo/issues/detail?id=5928

this was integrated with issue 5755


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker