Issue 5936 in pharo: DateAndTime DOS conversion

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug

New issue 5936 by [hidden email]: DateAndTime DOS conversion
http://code.google.com/p/pharo/issues/detail?id=5936

2.0

Neither #fromDosTime: nor #asDosTime seem to correctly translate from  
DateAndTime to DOS timestamps.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5936 by [hidden email]: DateAndTime DOS  
conversion
http://code.google.com/p/pharo/issues/detail?id=5936

Fix in inbox: Name:  
SLICE-Issue-5936-DateAndTime-DOS-conversion-SeanDeNigris.1

* Fix conversion to/from DateAndTime and DOS timestamps. DOS format per  
http://blogs.msdn.com/b/oldnewthing/archive/2003/09/05/54806.aspx and  
http://mindprod.com/jgloss/zip.html
* Update tests, removing #testAsDosTimeIndependentOfTimezone (they are not  
independent; DOS timestamps are in local time)
* Renamed DateAndTime>>asDosTime to #asDosTimestamp (it is not a time, but  
an encoded date/time)
* Renamed DateAndTime class>>fromDosSeconds: to #fromDosTimestamp (it is  
not a number of seconds, like a UNIX or Squeak date/time)
* Updated ZipArchiveMember to use new method names


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5936 by [hidden email]: DateAndTime DOS  
conversion
http://code.google.com/p/pharo/issues/detail?id=5936

The DOS-related logic in DateAndTime was way too complicated and needed to  
be commented and broken up into smaller methods, so I created a  
DosTimestamp class, and moved it all there...

Updated fix in inbox:  
SLICE-Issue-5936-DateAndTime-DOS-conversion-SeanDeNigris.3

* Create DosTimestamp class, and move all DOS-related logic out of  
DateAndTime
* Update and add tests, which all pass


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5936 by [hidden email]: DateAndTime DOS  
conversion
http://code.google.com/p/pharo/issues/detail?id=5936

I had forgotten to deprecate the renamed methods from DateAndTime...

SLICE-Issue-5936-DateAndTime-DOS-conversion-SeanDeNigris.4

* deprecate methods instead of removing


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5936 by [hidden email]: DateAndTime DOS  
conversion
http://code.google.com/p/pharo/issues/detail?id=5936

Maybe I will get this slice right eventually!

This version fixes the 2 deprecations to call the new methods.

SLICE-Issue-5936-DateAndTime-DOS-conversion-SeanDeNigris.5

Here's the summary of changes through all 5 versions...
* Fix conversion to/from DateAndTime and DOS timestamps. DOS format per  
http://blogs.msdn.com/b/oldnewthing/archive/2003/09/05/54806.aspx and  
http://mindprod.com/jgloss/zip.html
* Deprecated and renamed DateAndTime>>asDosTime to #asDosTimestamp (it is  
not a time, but an encoded date/time)
* Deprecated and renamed DateAndTime class>>fromDosSeconds: to  
#fromDosTimestamp (it is not a number of seconds, like a UNIX or Squeak  
date/time)
* Updated ZipArchiveMember to use new method names
* Create DosTimestamp class, and move all DOS-related logic out of  
DateAndTime
* Update tests, removing #testAsDosTimeIndependentOfTimezone (they are not  
independent; DOS timestamps are in local time), and add tests, which all  
pass


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-2.0

Comment #5 on issue 5936 by [hidden email]: DateAndTime DOS  
conversion
http://code.google.com/p/pharo/issues/detail?id=5936

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 5936 by [hidden email]: DateAndTime DOS  
conversion
http://code.google.com/p/pharo/issues/detail?id=5936

looks good


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 5936 by [hidden email]: DateAndTime DOS  
conversion
http://code.google.com/p/pharo/issues/detail?id=5936

in 2.0 097


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker