Issue 5975 in pharo: Cleanup after using FileSystem everywhere

Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Feature

New issue 5975 by [hidden email]: Cleanup after using FileSystem  
everywhere
http://code.google.com/p/pharo/issues/detail?id=5975

- Remove all the methods that became obsolete by using FileSystem as base  
system
- Remove all the FileDirectory related classes



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Labels: -Type-Feature Type-Bug

Comment #1 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975

Here's a start...

In #20134, the following fails (DNU):
     Gofer it
        directory: '/Users/sean/Downloads/';
        package: 'Metacello-Base';
        load.
Fix in inbox:  
SLICE-Issue-5975-Cleanup-after-using-FileSystem-everywhere-SeanDeNigris.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975

Here's an updated SLICE that also fixes MCCacheRepository:  
SLICE-Issue-5975-Cleanup-after-using-FileSystem-everywhere-SeanDeNigris.2

Post-load, you must evaluate: "MCCacheRepository instVarNamed: 'default'  
put: nil"


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Blockedon: -pharo:5967 pharo:5967

Comment #3 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975

What we should do is to look at all the methods in the FileDirectory API  
and check if they are called.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975

Are you sure about the hash definition?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Filesystem

Comment #5 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #6 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975#c6

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #7 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975#c7

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-5975-Cleanup-after-using-FileSystem-everywhere-SeanDeNigris.2  
from http://ss3.gemstone.com/ss/PharoInbox:
        MCMergeOrLoadWarning: You are about to load new versions of the following  
packages
that have unsaved changes in the image:

   Monticello
   Monticello

If you continue, you will lose these changes:
  1: MCVersionLoader>>warnAboutLosingChangesTo:ifCancel:ifMerge:
  2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge:
  3: MCVersionLoader>>loadWithNameLike:
  4: MCVersionLoader>>load
  5: GoferLoad>>execute
  6: Gofer>>execute:do:
  7: Gofer>>execute:
  8: Gofer>>load
  9: GoferResolvedReference>>load
10: [self slice load] in ChangeLoader>>loadSlice
        ...Test Results:
-------------
Passed: 5267
        CollectionsTests-Arrayed (562)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (907)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (592)
        CollectionsTests-Support (12)
        CollectionsTests-Text (45)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Monticello (104)

Errors: 1
        MCDirectoryRepositoryTest>>#testAddAndLoad


----------------------------------------------------------
Loaded Source:  
SLICE-Issue-5975-Cleanup-after-using-FileSystem-everywhere-SeanDeNigris.2  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20172-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #8 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975

Fix in inbox:  
SLICE-Issue-5975-Cleanup-after-using-FileSystem-everywhere-SeanDeNigris.3

Most of the changes from the last version of the slice were already  
integrated in other fixes...

These two were still relevant:
* change an argument name from aFileDirectory to aFileReference
* Refactor MCDirectoryRepository>>includesFileNamed: for clarity. There is  
a note in the implementation that it's a cache to speed up cache hits,  
but "10000 timesRepeat:" took ~3950ms with the original implementation and  
~4150ms with my simplification, consistently over several runs. Unless  
someone speaks up, I think the simple code is worth the extra .02ms per  
check


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #9 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975#c9

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #10 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975#c10

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-5975-Cleanup-after-using-FileSystem-everywhere-SeanDeNigris.3  
from http://ss3.gemstone.com/ss/PharoInbox:
        MCMergeOrLoadWarning: You are about to load new versions of the following  
packages
that have unsaved changes in the image:

   Monticello
   Monticello

If you continue, you will lose these changes:
  1: MCVersionLoader>>warnAboutLosingChangesTo:ifCancel:ifMerge:
  2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge:
  3: MCVersionLoader>>loadWithNameLike:
  4: MCVersionLoader>>load
  5: GoferLoad>>execute
  6: Gofer>>execute:do:
  7: Gofer>>execute:
  8: Gofer>>load
  9: GoferResolvedReference>>load
10: [self slice load] in ChangeLoader>>loadSlice
        ...Test Results:
-------------
Passed: 5267
        CollectionsTests-Arrayed (562)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (907)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (592)
        CollectionsTests-Support (12)
        CollectionsTests-Text (45)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Monticello (104)

Errors: 1
        MCDirectoryRepositoryTest>>#testAddAndLoad


----------------------------------------------------------
Loaded Source:  
SLICE-Issue-5975-Cleanup-after-using-FileSystem-everywhere-SeanDeNigris.3  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20172-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975

includesFileNamed: was optimizied bu camillo for *huge* directories with  
1000nds of files (package cache).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975

looks fine. With the new file primitives we don't have to use the crappy  
FileStream hack anymore.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #13 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #14 on issue 5975 by [hidden email]: Cleanup after using  
FileSystem everywhere
http://code.google.com/p/pharo/issues/detail?id=5975

in 2.0 189


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker