Issue 5977 in pharo: Rpackage may not handle well method removal in traits

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug

New issue 5977 by [hidden email]: Rpackage may not handle well  
method removal in traits
http://code.google.com/p/pharo/issues/detail?id=5977

While looking at testRemovingMethods it occurred to me that may be RPackage  
does not handle method removal in traits.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5977 by [hidden email]: Rpackage may not  
handle well method removal in traits
http://code.google.com/p/pharo/issues/detail?id=5977

In the system integration, RPackage is doing something like

aMethod isProvidedByTrait ifTrue: [ ^self ].

What has sense if the method is not provided by a trait.  But if it is a  
trait method it ends up in not adding nor removing it...

I propose to change that check by something like

aMethod origin = ann itemClass ifFalse: [ ^self ].

I'll provide an slice


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Labels: Milestone-2.0

Comment #2 on issue 5977 by [hidden email]: Rpackage may not  
handle well method removal in traits
http://code.google.com/p/pharo/issues/detail?id=5977

In the inbox

SLICE-Issue-5977-Rpackage-may-not-handle-well-method-removal-in-traits-
GuillermoPolito.4

some fixes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5977 by [hidden email]: Rpackage may not  
handle well method removal in traits
http://code.google.com/p/pharo/issues/detail?id=5977

SLICE-Issue-5977-Rpackage-may-not-handle-well-method-removal-in-traits-GuillermoPolito.5

respects some of the last rpackage fixes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 5977 by [hidden email]: Rpackage may not handle  
well method removal in traits
http://code.google.com/p/pharo/issues/detail?id=5977

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #5 on issue 5977 by [hidden email]: Rpackage may not handle  
well method removal in traits
http://code.google.com/p/pharo/issues/detail?id=5977

in 110


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #6 on issue 5977 by [hidden email]: Rpackage may not handle  
well method removal in traits
http://code.google.com/p/pharo/issues/detail?id=5977

Issue 6018 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker