Issue 5992 in pharo: testMethodsWithUnboundGlobals

Status: FailingTest
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 5992 by [hidden email]: testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

in: 20100 and previous

Error Message

Assertion failed
Stacktrace

ReleaseTest(TestCase)>>signalFailure:
ReleaseTest(TestCase)>>assert:
ReleaseTest>>testMethodsWithUnboundGlobals
ReleaseTest(TestCase)>>performTest


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5992 by marianopeck: testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

I cannot reproduce it locally in my MacOSX :(


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

it seems to be green on Linux too. Even if executed from command line. I  
guess that any different test that is executed before causes this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

Interesting, I tried to check methodsWithUnboundGlobals after execution of  
every single test and I have not found any...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

I think the problem are methods created by the tests.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

I tried log it directly on Jenkins and the result is: MCDirtyPackageInfo  
methods


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

MCPackageTest is the dirty test


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

Probably MCDirtyPackageInfo>>#methods should be an extension method of  
MonticelloMocks.  Becayse the mc test resource unloads the class  
MCMockClassA and then it loads it again, but it assumes that class was not  
in the system, so it does not recompile all the source again.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

That or make the binding not strict with:

Smalltalk globals at: #MCMockClassA
...
...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

I've tested that and it solves the problem.  So, which solution? The  
packaging of these tests sucks, so I do not prefer any over the other, he.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #10 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

Slice in inbox:  
SLICE-Issue-5992-testMethodsWithUnboundGlobals-GuillermoPolito.1

Pavel, can you review besides the monkey? You've to run the tests on  
MCPackage tests and they may not create methods with unbound globals.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #11 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992#c11

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #12 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992#c12

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-5992-testMethodsWithUnboundGlobals-GuillermoPolito.1 from  
http://ss3.gemstone.com/ss/PharoInbox:
        MCMergeOrLoadWarning: You are about to load new versions of the following  
packages
that have unsaved changes in the image:

   Monticello
   Monticello

If you continue, you will lose these changes:
  1: MCVersionLoader>>warnAboutLosingChangesTo:ifCancel:ifMerge:
  2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge:
  3: MCVersionLoader>>loadWithNameLike:
  4: MCVersionLoader>>load
  5: GoferLoad>>execute
  6: Gofer>>execute:do:
  7: Gofer>>execute:
  8: Gofer>>load
  9: GoferResolvedReference>>load
10: [self slice load] in UlysseTheMonkey>>loadSlice
        ...Test Results:
-------------
Passed: 6447
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (578)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Monticello (120)

Errors: 1
        MCDirectoryRepositoryTest>>#testAddAndLoad


----------------------------------------------------------
Loaded Source:  
SLICE-Issue-5992-testMethodsWithUnboundGlobals-GuillermoPolito.1 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20187-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  5 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  5 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
8216bc960dcf8ddab3a2f6fb54cc97214e7797fd Date: Thu Jul 5 09:41:44 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixManualReviewNeeded

Comment #13 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

Merging the slice works.  The problem is that there were things integrated  
in the middle...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #14 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

Works fine


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

in 2.0 192


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #16 on issue 5992 by [hidden email]:  
testMethodsWithUnboundGlobals
http://code.google.com/p/pharo/issues/detail?id=5992

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker