Issue 6005 in pharo: BlockClosure>>silentlyValue doesn't silence nested progress bars

Status: New
Owner: [hidden email]
Labels: Milestone-2.0 Type-Bug

New issue 6005 by [hidden email]: BlockClosure>>silentlyValue doesn't  
silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

To reproduce, evaluate next code and you can check that the main progress  
bar is effectively silenced, but the nested ones not.

[
'main task'
        displayProgressFrom: 0 to: 5
        during: [ :bar |
                0 to: 5 do: [:x | bar value: x.
                (Delay forMilliseconds: 200) wait.

                'nested task ' , x printString
                        displayProgressFrom: 5 to: 10
                        during: [ :bar2 |
                                5 to: 10 do: [:x2 | bar2 value: x2.
                                (Delay forMilliseconds: 200) wait] ] ] ].

] silentlyValue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Invalid

Comment #1 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

the api has been changed and silentlyValue has been fixed.. can you check  
in the current image?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

I checked in #20175 and still happens. The code to reproduce must change  
its "value:" to "current:":

[
'main task'
        displayProgressFrom: 0 to: 5
        during: [ :bar |
                0 to: 5 do: [:x | bar current: x.
                (Delay forMilliseconds: 200) wait.

                'nested task ' , x printString
                        displayProgressFrom: 5 to: 10
                        during: [ :bar2 |
                                5 to: 10 do: [:x2 | bar2 current: x2.
                                (Delay forMilliseconds: 200) wait] ] ] ].

] silentlyValue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

Note that a workaround is wrapping like "[ snippet ] silentlyValue", i.e.  
with another level of silentlyValue.

But if we add another nested bar... then the issue happens again:

[[
'main task'
        displayProgressFrom: 0 to: 5
        during: [ :bar |
                0 to: 5 do: [:x |
                        bar current: x.
                        (Delay forMilliseconds: 100) wait.

                        'nested task ' , x printString
                                displayProgressFrom: 5 to: 10
                                during: [ :bar2 |
                                        5 to: 10 do: [:x2 |
                                                bar2 current: x2.
                                                (Delay forMilliseconds: 100) wait.
                                       
                  'nested bis task ' , x2 printString
                                                        displayProgressFrom: 10 to: 15
                                                        during: [ :bar3 |
                                                                10 to: 15 do: [:x3 |
                                                                        bar3 current: x3.
                                                                        (Delay forMilliseconds: 100) wait] ] ] ] ] ].

] silentlyValue.
] silentlyValue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

I got it! silentlyValue should be sent recursively:

silentlyValue
        "evaluates the receiver but avoiding progress bar notifications to show  
up."
       
        ^[ self value ]
                on: ProgressInitiationException
                do: [ :ex | [ ex sendNotificationsTo: LoggingSystemProgressItemMorph new  
] silentlyValue ].


I will write a test and make a slice.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

Indeed, this message must be in another package and not in  
BlockClosure 'evaluating' protocol, as it's now. Look:

ProgressInitiationException category ---> #'UIManager-Support'
LoggingSystemProgressItemMorph category ---> #'Morphic-Widgets'


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #6 on issue 6005 by marianopeck: BlockClosure>>silentlyValue  
doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #7 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

I didn't change the package, but uploaded into PharoInbox:

Name:  
SLICE-Issue-6005-BlockClosuregtgtsilentlyValue-doesnt-silence-nested-progress-bars-MartinDias.1
Author: MartinDias
Time: 1 July 2012, 8:57:42.111 pm
UUID: a51cbe0b-e121-d342-9e8a-565593911f44
Ancestors:
Dependencies: KernelTests-MartinDias.420, Kernel-MartinDias.1130,  
Kernel-Methods-MartinDias.1

Fix: Send recursively BlockClosure>>silentlyValue. Anyway, as Igor said,  
maybe this method has not much sense... I'm not using it, I just saw it was  
failing and reported it.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #8 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005#c8

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #9 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005#c9

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6005-BlockClosuregtgtsilentlyValue-doesnt-silence-nested-progress-bars-MartinDias.1  
from http://ss3.gemstone.com/ss/PharoInbox:
        MCMergeOrLoadWarning: You are about to load new versions of the following  
packages
that have unsaved changes in the image:

   KernelTests
   KernelTests

If you continue, you will lose these changes:
  1: MCVersionLoader>>warnAboutLosingChangesTo:ifCancel:ifMerge:
  2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge:
  3: MCVersionLoader>>loadWithNameLike:
  4: MCVersionLoader>>load
  5: GoferLoad>>execute
  6: Gofer>>execute:do:
  7: Gofer>>execute:
  8: Gofer>>load
  9: GoferResolvedReference>>load
10: [self slice load] in ChangeLoader>>loadSlice
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6005-BlockClosuregtgtsilentlyValue-doesnt-silence-nested-progress-bars-MartinDias.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20175-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

This is is annoying... lets deprecate it and be done.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

Why the monkey went bananas? There was something wrong in my slice?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: NextActionNeeded

Comment #12 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

Probably the fix became out of date when other fixes to the same packages  
were integrated. If you merge the slice into the latest update of Pharo and  
then save a new version, it should be okay.

@Marcus: why integrated? If we're deprecating, will that be another issue,  
or should we put that fix here?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

I deprecated it.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #14 on issue 6005 by [hidden email]:  
BlockClosure>>silentlyValue doesn't silence nested progress bars
http://code.google.com/p/pharo/issues/detail?id=6005

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker