Issue 6013 in pharo: TAnnouncer

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Milestone-2.0 Type-Feature Difficulty-Easy

New issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013


The tipical behavior of an object that has an announcer is more or less the  
same wherever. So, that behavior can be defined on a Trait.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

SLICE-Issue-6013-TAnnouncer-SantiagoBragagnolo.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #2 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #3 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

we need to think if we want this inside the image


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

Come on, it is a just a trait that abstracts some useful behavior. If not,  
you are forced to repeat all this or inherit from Announcer...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

Yeap, id use it two times of three times i need an announcer :P. (and the  
one when i didn't use it was the first time)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #7 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

Problem with this is that nobody will use it unless we allocate also time  
to move all our stuff to use it (so people can actually use it). Same  
happens with TAssertable (is there, nobody uses it, and now is duplicated  
code)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Target-Trait

Comment #9 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Sprint

Comment #10 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

Ok, i added 4 use cases in the Announcement-support-test package. As i said  
in the commit comment, there are not tests in this package but use cases  
and comments about each kind of solution. If we add this trait into the  
main package, i can refactor the package level uses of announcers. If not,  
i'll commitit into CommonTraits (ss3) which is a project of tiny and useful  
traits for common and transversal behaviors.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #12 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

Look at the comment 11


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #13 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013#c13

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #14 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013#c14

Monkey went bananas:
--------------------
Error while loading SLICE-Issue-6013-TAnnouncer-SantiagoBragagnolo.2 from  
http://ss3.gemstone.com/ss/PharoInbox:
        MessageNotUnderstood: GoferResolvedReference>>merge
  1: GoferResolvedReference(Object)>>doesNotUnderstand: #merge
  2: [self slice merge] in UlysseTheMonkey>>loadSlice
  3: BlockClosure>>on:do:
  4: UlysseTheMonkey>>loadSlice
  5: [self loadSlice] in UlysseTheMonkey>>loadAndTestSlice
  6: [loadStopwatch reset activate.
                aBlock value.
                loadStopwatch suspend.
                testResult := self runTests.
                self removeFalseErrors] in UlysseTheMonkey>>testChangeImpact:
  7: BlockClosure>>on:do:
  8: UlysseTheMonkey>>testChangeImpact:
  9: UlysseTheMonkey>>loadAndTestSlice
10: UlysseTheMonkey>>loadAndTest
        ...Test Results:
-------------
Passed: 6404
        Announcements-Tests-Core (29)
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (606)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (180)
        KernelTests-Chronology (592)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (37)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)


Failures: 1
        TimeTest>>#testGeneralInquiries

----------------------------------------------------------
Loaded Source: SLICE-Issue-6013-TAnnouncer-SantiagoBragagnolo.2 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20377-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct 26 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct 26 2012
git://gitorious.org/cogvm/blessed.git Commit:  
48af8595004fd0ec3a3ac6d44c3d7516a87981ca Date: 2012-10-24 16:56:20 +0200  
By: Igor Stasenko <[hidden email]> Jenkins build #131


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #15 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

Yes, this is cause of the slice, it have all the announcement package, and  
it brokes when its re-writing it and in the same time making  
announcements.  Theres any way to avoid to commit the whole package in the  
slice but the really changed ones?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #19 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013#c19

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #20 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #21 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #22 on issue 6013 by [hidden email]: TAnnouncer
http://code.google.com/p/pharo/issues/detail?id=6013

my 2c:
this is one of the cases, where it hard to determine whether we using  
traits to avoid code duplication or we're using them just for the sake of  
it.
Because, as previous commentators said, if nobody will use it, it will just  
make codebase bigger, and if you start using it just to prove that it is  
useful, then this is exactly falls to "using traits because we can" case.

For example, in my various projects i using many separate classes which  
implement single-linked list behavior: with #next, #next:  and #do: methods  
etc... so it is tempting to define a trait for them..
but the amount of 'same code' there is too small to shape it into trait,  
and usually those classes come with some additional special behavior (even  
including above methods), where linked list is just a small part of puzzle.
Maybe it is really worth defining a trait, as a way to state a public  
protocol aka interface for single-linked lists, but clearly not for  
avoiding code duplication (it is negligible small and often needs  
overrides).

so, i do not know.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker