Status: Accepted
Owner:
[hidden email]
Labels: Type-Bug
New issue 6016 by
[hidden email]: privateAnnouncer is not used and
this is not good
http://code.google.com/p/pharo/issues/detail?id=6016PackageOrganizer should register to the private Announcer of
SystemAnnoucement.
Now we recently changed it to register to the public one
See
announcer
"PRIVATE - Do not use this announcer to register to receive events. Use
SystemAnnouncer instead"
^ SystemAnnouncer announcer
Now it should be
announcer
"PRIVATE - Do not use this announcer to register to receive events. Use
SystemAnnouncer instead"
^ SystemAnnouncer privateAnnouncer
It measn that some tests should adapt their setup and teardown
RPackageTestCase>>initializeAnnouncers
oldMCAnnouncer := SystemAnnouncer announcer.
SystemAnnouncer announcer: SystemAnnouncer new.
oldPrivateAnnouncer := SystemAnnouncer privateAnnouncer.
SystemAnnouncer privateAnnouncer: SystemAnnouncer new.
RPackageTestCase>>restoreAnnouncers
SystemAnnouncer announcer: oldMCAnnouncer.
SystemAnnouncer privateAnnouncer: oldPrivateAnnouncer.
SystemNavigationTestsetUp>>
super setUp.
oldMonticelloAnnouncer := SystemAnnouncer announcer.
SystemAnnouncer announcer: nil.
oldPrivateAnnouncer := SystemAnnouncer announcer.
SystemAnnouncer privateAnnouncer: nil.
navigator := self createSystemNavigationToTest.
classFactory := self createClassFactory.
RPackageTestCase>>tearDown
super tearDown.
self classFactory cleanUp.
SystemAnnouncer announcer: oldMonticelloAnnouncer.
SystemAnnouncer privateAnnouncer: oldPrivateAnnouncer
TraitsResource>>setUp
"Please note, that most tests rely on this setup of traits and
classes - and that especially the order of the definitions matters."
"SetUpCount := SetUpCount + 1."
dirty := false.
oldAnnouncer := SystemAnnouncer announcer.
oldPrivateAnnouncer := SystemAnnouncer privateAnnouncer.
SystemAnnouncer announcer: nil.
SystemAnnouncer privateAnnouncer: nil.
SystemChangeNotifier uniqueInstance doSilently:
[self t1: (self createTraitNamed: #T1
uses: { }).
self t1 comment: 'I am the trait T1'.
self t2: (self createTraitNamed: #T2
uses: { }).
self t2 compile: 'm21 ^21' classified: #cat1.
self t2 compile: 'm22 ^22' classified: #cat2.
self t2 classSide compile: 'm2ClassSide: a ^a'.
self t3: (self createTraitNamed: #T3
uses: { }).
self t3 compile: 'm31 ^31' classified: #cat1.
self t3 compile: 'm32 ^32' classified: #cat2.
self t3 compile: 'm33 ^33' classified: #cat3.
self t4: (self createTraitNamed: #T4
uses: { (self t1). (self t2) }).
self t4 compile: 'm11 ^41' classified: #catX. "overrides T1>>m11"
self t4 compile: 'm42 ^42' classified: #cat2.
self t5: (self createTraitNamed: #T5 uses: self t1 + self t2).
self t5 compile: 'm51 ^super foo' classified: #cat1.
self t5 compile: 'm52 ^ self class bar' classified: #cat1.
self t5 compile: 'm53 ^ self class bar' classified: #cat1.
self t6: (self createTraitNamed: #T6
uses: (self t1 + self t2) @ { (#m22Alias -> #m22) }).
self c1: (self
createClassNamed: #C1
superclass: Object
uses: { }).
self c1 compile: 'foo ^true' classified: #accessing.
self t1 compile: 'm11 ^11' classified: #cat1.
self t1 compile: 'm12 ^12' classified: #cat2.
self t1 compile: 'm13 ^self m12' classified: #cat3.
self c2: (self
createClassNamed: #C2
superclass: self c1
uses: self t5 - { #m11 }).
self c2 compile: 'foo ^false' classified: #private.
self c2 compile: 'bar ^self foo' classified: #private.
self setUpTrivialRequiresFixture.
self setUpTwoLevelRequiresFixture.
self setUpTranslatingRequiresFixture].
SystemChangeNotifier uniqueInstance notify: self ofAllSystemChangesUsing:
#codeChangedEvent:
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Locked
