Issue 6019 in pharo: Collection>>#difference: behaviour change between 1.3 and 1.4

Status: New
Owner: ----
Labels: Milestone-1.4 Type-Bug

New issue 6019 by [hidden email]: Collection>>#difference:  
behaviour change between 1.3 and 1.4
http://code.google.com/p/pharo/issues/detail?id=6019

With Pharo-1.4-14438-OneClick.zip

Executing the following in Workspace...
      20 timesRepeat:
      [
          one := TextMorph new newContents: '1'.
          two := TextMorph new newContents: '2'.
          collection := (OrderedCollection with: one with: two).
          diff := collection difference: OrderedCollection new.
         Transcript crShow: diff first text, diff second text.
      ]

In Pharo-1.3-13315-OneClick, every line consistently says '12'.
In Pharo-1.4-14438-OneClick, the lines alternate randomly between '12'  
& '21'.

Mondrian/Roassal in particular relies on the consistency of the result from  
#difference for consistent graph generation from the same data.

Pharo 1.3 has...
Collection>>difference: aCollection
      "Answer the set theoretic difference of two collections."
      ^ self reject: [:each | aCollection includes: each]

Pharo 1.4 has...
Collection>>difference: aCollection
      "Answer the set theoretic difference of two collections."
      | set|
      set := self asSet.
      aCollection do: [ :each|
          set remove: each ifAbsent: []].
      ^ self species withAll: set asArray


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #1 on issue 6019 by [hidden email]: Collection>>#difference:  
behaviour change between 1.3 and 1.4
http://code.google.com/p/pharo/issues/detail?id=6019

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-2.0

Comment #2 on issue 6019 by [hidden email]: Collection>>#difference:  
behaviour change between 1.3 and 1.4
http://code.google.com/p/pharo/issues/detail?id=6019

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #3 on issue 6019 by [hidden email]: Collection>>#difference:  
behaviour change between 1.3 and 1.4
http://code.google.com/p/pharo/issues/detail?id=6019

SLICE-Issue-6019-Collectiongtgtdifference-behaviour-change-between-13-and-14-CamilloBruni.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #4 on issue 6019 by [hidden email]: Collection>>#difference:  
behaviour change between 1.3 and 1.4
http://code.google.com/p/pharo/issues/detail?id=6019

change breaks tests:

4939 run, 4915 passes, 0 expected failures, 0 failures, 24 errors, 0  
unexpected passes
Failures:

Errors:
IntervalTest>>#testCopyEmptyWithout
IntervalTest>>#testCopyEmptyWithoutAll
IntervalTest>>#testCopyNonEmptyWithout
IntervalTest>>#testCopyNonEmptyWithoutAll
IntervalTest>>#testCopyNonEmptyWithoutAllNotIncluded
IntervalTest>>#testCopyNonEmptyWithoutNotIncluded
IntervalTest>>#testReject
IntervalTest>>#testRejectEmpty
IntervalTest>>#testRejectNoReject
IntervalTest>>#testSelect
IntervalTest>>#testSelectOnEmpty
SymbolTest>>#testCopyEmptyWithout
SymbolTest>>#testCopyEmptyWithoutAll
SymbolTest>>#testCopyNonEmptyWithout
SymbolTest>>#testCopyNonEmptyWithoutAll
SymbolTest>>#testCopyNonEmptyWithoutNotIncluded
SymbolTest>>#testDifference
SymbolTest>>#testDifferenceWithSeparateCollection
SymbolTest>>#testReject
SymbolTest>>#testRejectEmpty
SymbolTest>>#testRejectNoReject
SymbolTest>>#testSelect
SymbolTest>>#testSelectOnEmpty
WeakSetTest>>#testCollisions


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #5 on issue 6019 by [hidden email]: Collection>>#difference:  
behaviour change between 1.3 and 1.4
http://code.google.com/p/pharo/issues/detail?id=6019

reverted wrongly implemented #select: on SequenceablCollection

SLICE-Issue-6019-Collectiongtgtdifference-behaviour-change-between-13-and-14-CamilloBruni.2


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 6019 by [hidden email]: Collection>>#difference:  
behaviour change between 1.3 and 1.4
http://code.google.com/p/pharo/issues/detail?id=6019

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 6019 by [hidden email]: Collection>>#difference:  
behaviour change between 1.3 and 1.4
http://code.google.com/p/pharo/issues/detail?id=6019

select: ?
Ok I integrated version 2.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker