Issue 6023 in pharo: Enhance MCHttpRepository>>readStreamForFileNamed:do: to require binary data

Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Feature

New issue 6023 by [hidden email]: Enhance  
MCHttpRepository>>readStreamForFileNamed:do: to require binary data
http://code.google.com/p/pharo/issues/detail?id=6023

Enhancement to help enforce MCHttpRepository>>readStreamForFileNamed:do to  
require binary data from the server. Done using ZnClient>>#accept:  
with 'application/*' as mime-type. This matches the two most common cases:  
application/octet-stream and application/x-monticello but it is not 100%.

Improve MCHttpRepository error handling.

Refactor ZnClient creation in MCHttpRepository in #httpClient helper method.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6023 by [hidden email]: Enhance  
MCHttpRepository>>readStreamForFileNamed:do: to require binary data
http://code.google.com/p/pharo/issues/detail?id=6023

In inbox:

Enhancement to help enforce MCHttpRepository>>readStreamForFileNamed:do to  
require binary data from the server. Done using ZnClient>>#accept:  
with 'application/*' as mime-type. This matches the two most common cases:  
application/octet-stream and application/x-monticello but it is not 100%.

Improve MCHttpRepository error handling.

Refactor ZnClient creation in MCHttpRepository in #httpClient helper method.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 6023 by [hidden email]: Enhance  
MCHttpRepository>>readStreamForFileNamed:do: to require binary data
http://code.google.com/p/pharo/issues/detail?id=6023

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #3 on issue 6023 by [hidden email]: Enhance  
MCHttpRepository>>readStreamForFileNamed:do: to require binary data
http://code.google.com/p/pharo/issues/detail?id=6023

looks good


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #4 on issue 6023 by [hidden email]: Enhance  
MCHttpRepository>>readStreamForFileNamed:do: to require binary data
http://code.google.com/p/pharo/issues/detail?id=6023

in 2.0 112


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Owner: [hidden email]
        Cc: [hidden email] [hidden email]

Comment #5 on issue 6023 by [hidden email]: Enhance  
MCHttpRepository>>readStreamForFileNamed:do: to require binary data
http://code.google.com/p/pharo/issues/detail?id=6023

This change breaks smalltalkhub.
That can be because smalltalkhub is not sending the files with mime  
type "application/*"... but I wonder why that needs to be forced...
how can we fix it?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6023 by [hidden email]: Enhance  
MCHttpRepository>>readStreamForFileNamed:do: to require binary data
http://code.google.com/p/pharo/issues/detail?id=6023

Try accessing the URL of any MC version directly, as in

ZnEasy get: 'http://smalltalkhub.com/foo/bar.mcz'.

and look at the content-type of the response.

As a new service Smalltalkhub should definitively serve the .mzc files as  
application/x-monticello


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 6023 by [hidden email]: Enhance  
MCHttpRepository>>readStreamForFileNamed:do: to require binary data
http://code.google.com/p/pharo/issues/detail?id=6023

OK, I just tried myself.

It uses the mime-type binary/octet-stream

I never heard of that one before, it is not in /etc/mime.types on Ubuntu,  
it is not listed in the main Wikipedia article on mime-types.

I would change this to application/octet-stream or application/x-monticello


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #8 on issue 6023 by [hidden email]: Enhance  
MCHttpRepository>>readStreamForFileNamed:do: to require binary data
http://code.google.com/p/pharo/issues/detail?id=6023

Name:  
SLICE-Issue-6023-Enhance-MCHttpRepository-Rewritten-Assertions-SvenVanCaekenberghe.1
Author: SvenVanCaekenberghe
Time: 5 June 2012, 10:05:22.04 pm
UUID: 5eb1e106-e5af-4ccc-927d-f3b4de480cb3
Ancestors:
Dependencies: Monticello-SvenVanCaekenberghe.605

rewrote the assertion logic in MCHttpRepository again to really look at the  
returned mime-type instead of using #accept:
refactored a bit of code


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 6023 by [hidden email]: Enhance  
MCHttpRepository>>readStreamForFileNamed:do: to require binary data
http://code.google.com/p/pharo/issues/detail?id=6023

thanks Sven :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 6023 by [hidden email]: Enhance  
MCHttpRepository>>readStreamForFileNamed:do: to require binary data
http://code.google.com/p/pharo/issues/detail?id=6023

in 20113


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker