Issue 6038 in pharo: ProtoObject should NOT implement #rehash

Status: Accepted
Owner: marianopeck
CC: [hidden email]
Labels: Type-Enh

New issue 6038 by marianopeck: ProtoObject should NOT implement #rehash
http://code.google.com/p/pharo/issues/detail?id=6038

That is a hack, as its comment says:

ProtoObject >> rehash
        "Do nothing.  Here so sending this to a Set does not have to do a time  
consuming respondsTo:"

Well, a couple of things:

1) now we have HashedCollection superclass, so all we need to do is  
#isKindOf: HashedColletion

2) the ONLY place I found that sends #rehash to something that is NOT a  
HashedCollection is Object >> veryDeepCopyWith:.

So since considering that the isKindOf: is not *that* costly, and that we  
only use veryDeepCopy in a very few places, I recommend removing  
ProtoObject >> rehash  and add the isKinfOf:  to #veryDeepCopyWith:

Slice is coming in case you agree


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6038 by marianopeck: ProtoObject should NOT implement  
#rehash
http://code.google.com/p/pharo/issues/detail?id=6038

Fix in inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-2.0

Comment #2 on issue 6038 by marianopeck: ProtoObject should NOT implement  
#rehash
http://code.google.com/p/pharo/issues/detail?id=6038

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #3 on issue 6038 by [hidden email]: ProtoObject should NOT  
implement #rehash
http://code.google.com/p/pharo/issues/detail?id=6038

looks good, but the slice does not remove the rehash but makes it read

rehash
        "Do nothing.  Here so sending this to a Set does not have to do a time  
consuming respondsTo:"
       
HashedCollection

the integrator should remove it


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6038 by marianopeck: ProtoObject should NOT implement  
#rehash
http://code.google.com/p/pharo/issues/detail?id=6038

ups...sorry marcus. Weird. I have check and you are right. The integrator  
should take the slice and then remove ProtoObjet>>rehash.
Thanks for reviewing!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6038 by [hidden email]: ProtoObject should NOT  
implement #rehash
http://code.google.com/p/pharo/issues/detail?id=6038

So what should we do.
I wanted to integrate it but got lost.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6038 by marianopeck: ProtoObject should NOT implement  
#rehash
http://code.google.com/p/pharo/issues/detail?id=6038

Just integrate the slice and then after remove ProtoObject>>rehash.  
Otherwise, I upload a new slice.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 6038 by [hidden email]: ProtoObject should NOT  
implement #rehash
http://code.google.com/p/pharo/issues/detail?id=6038

Ok I will do it now.

Stef


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #8 on issue 6038 by [hidden email]: ProtoObject should NOT  
implement #rehash
http://code.google.com/p/pharo/issues/detail?id=6038

in 20118


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker