Issue 6049 in pharo: Monticello Browser repository List and repositories out of sync when searching

Status: New
Owner: ----
Labels: Milestone-1.4 Type-Bug Milestone-2.0

New issue 6049 by [hidden email]: Monticello Browser repository List and  
repositories out of sync when searching
http://code.google.com/p/pharo/issues/detail?id=6049

In MonticelloBrowser (MCWorkingCopyBrowser), the repositoryList method is  
aware of search patterns, but repositories is not.

If you enter some search pattern, and click on the first element in the  
list, the repository is set to the first item in repositories, rather than  
the repository with the description selected.

Modify the repositories method to select the matching items if pattern is  
not nil, and remove this logic from repositoryList.

Slice will be sent, code follows.


repositoryList
        |repositories|
        repositories := self repositories.

        ^ repositories collect: [:ea | ea description]

repositories
        |repositories|
        repositories := self repositoryGroup repositories.
       
        "filter the repository list if there is a search string"
        repositoryPattern ifNotNil: [
                repositories := repositories select: [ :each| repositoryPattern search:  
each description]].
        ^ repositories


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6049 by [hidden email]: Monticello Browser repository  
List and repositories out of sync when searching
http://code.google.com/p/pharo/issues/detail?id=6049

If I'd thought better, I might have said

repositoryList
    ^ self repositories collect: [:ea | ea description].


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 6049 by [hidden email]: Monticello Browser  
repository List and repositories out of sync when searching
http://code.google.com/p/pharo/issues/detail?id=6049

Thanks a lot dan.
Can you sign the license agreement and send it to us?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated
        Labels: -Milestone-1.4

Comment #3 on issue 6049 by [hidden email]: Monticello Browser  
repository List and repositories out of sync when searching
http://code.google.com/p/pharo/issues/detail?id=6049

in 20122


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker