Issue 6069 in pharo: Test guard for 20132

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 6069 by [hidden email]: Test guard for 20132
http://code.google.com/p/pharo/issues/detail?id=6069

 From http://forum.world.st/Tests-Guard-report-for-20132-td4634905.html:
as expected we have a lot of new failing tests:
   * CompressionTests.Archive.ZipArchiveTest.testCreateWithRelativeNames
   * CompressionTests.Archive.ZipArchiveTest.testFilePermissions
   * CompressionTests.Archive.ZipArchiveTest.testZip
   * FileSystem.Tests.Disk.DiskFileSystemTest.testRootIsNotAFile
   * Gofer.Tests.GoferApiTest.testDirectoryRepository
   * Gofer.Tests.GoferApiTest.testSubDirectoryRepository
   *  
RPackage.Tests.RPackageImportFromPackageInfoTest.testImportExtensionFromParentPackageRegisterExtensionInParentPackage
   * SUnit.Tests.Core.SUnitTest.testDialectLocalizedException
   * SUnit.Tests.Core.TestCaseTest.testAssertEqualsActualAndExpectedOrder
   * Tests.Monticello.MCFileInTest.testStWriter
   * Tests.Monticello.MCMczInstallerTest.testInstallFromFile
   * Tests.Monticello.MCMczInstallerTest.testInstallFromStream
   * Tests.Monticello.MCMethodDefinitionTest.testCannotLoad
   * Tests.Monticello.MCMethodDefinitionTest.testComparison
   * Tests.Monticello.MCMethodDefinitionTest.testLoadAndUnload
   *  
Tests.Monticello.MCMethodDefinitionTest.testPartiallyRevertOverrideMethod
   * Tests.Monticello.MCMethodDefinitionTest.testRevertOldMethod
   * Tests.Monticello.MCMethodDefinitionTest.testRevertOverrideMethod
   * Tests.System.SmalltalkImageTest.testImageName
   * Tests.Traits.TraitTest.testTraitsMethodClassSanity

...and a lot of new Linux specific failing tests:
   * CompressionTests.Archive.ZipArchiveTest.testAddNonExistentFile
   * CompressionTests.Archive.ZipArchiveTest.testDate29Feb2000
   * CompressionTests.Archive.ZipArchiveTest.testPackDate
   * CompressionTests.Archive.ZipArchiveTest.testPackTime
   * CompressionTests.Archive.ZipArchiveTest.testSetLastModification
   * CompressionTests.Archive.ZipArchiveTest.testUnpackDate
   * CompressionTests.Archive.ZipArchiveTest.testUnpackTime
   * FileSystem.Tests.Core.FileReferenceTest.testRename
   * FileSystem.Tests.Disk.DiskFileSystemTest.testCreateDirectoryNoParent
   * FileSystem.Tests.Disk.DiskFileSystemTest.testEnsureDirectory
   *  
FileSystem.Tests.Disk.DiskFileSystemTest.testEnsureDirectoryCreatesParent
   * FileSystem.Tests.Disk.DiskFileSystemTest.testFileNames
   * FileSystem.Tests.Disk.DiskFileSystemTest.testReadStreamDoIfAbsent
   * FileSystem.Tests.Disk.DiskFileSystemTest.testReadStreamIfAbsent
   * FileSystem.Tests.Disk.DiskFileSystemTest.testWriteStreamDoIfPresent
   * FileSystem.Tests.Disk.DiskFileSystemTest.testWriteStreamIfPresent
   * FileSystem.Tests.Disk.FileHandleTest.testEnsureClosed
   * Graphics.Tests.Files.PNGReadWriterTest.test1BitColors
   * Graphics.Tests.Files.PNGReadWriterTest.test2BitColors
   * Graphics.Tests.Files.PNGReadWriterTest.test4BitColors
   * Graphics.Tests.Files.PNGReadWriterTest.test8BitColors
   * Multilingual.Tests.TextConversion.MultiByteFileStreamTest.testBasicChunk
   * Multilingual.Tests.TextConversion.MultiByteFileStreamTest.testBinaryUpTo
   * Tests.System.CommandLine.BasicCodeLoaderTest.testInstallSourceFilesFail


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6069 by [hidden email]: Test guard for 20132
http://code.google.com/p/pharo/issues/detail?id=6069

Fix in inbox: SLICE-Issue-6069-Test-guard-for-20132-SeanDeNigris.1

Make the following tests pass (per  
http://forum.world.st/Tests-Guard-report-for-20132-td4634905.html):
   * CompressionTests.Archive.ZipArchiveTest.testCreateWithRelativeNames
   * CompressionTests.Archive.ZipArchiveTest.testFilePermissions
   * CompressionTests.Archive.ZipArchiveTest.testZip
   * Gofer.Tests.GoferApiTest.testDirectoryRepository
   * Gofer.Tests.GoferApiTest.testSubDirectoryRepository
   * SUnit.Tests.Core.TestCaseTest.testAssertEqualsActualAndExpectedOrder
   * Tests.Monticello.MCFileInTest.testStWriter
   * Tests.Monticello.MCMczInstallerTest.testInstallFromFile
   * Tests.Monticello.MCMczInstallerTest.testInstallFromStream
   * Tests.Monticello.MCMethodDefinitionTest.testCannotLoad
   * Tests.Monticello.MCMethodDefinitionTest.testComparison
   * Tests.Monticello.MCMethodDefinitionTest.testLoadAndUnload
   *  
Tests.Monticello.MCMethodDefinitionTest.testPartiallyRevertOverrideMethod
   * Tests.Monticello.MCMethodDefinitionTest.testRevertOldMethod
   * Tests.Monticello.MCMethodDefinitionTest.testRevertOverrideMethod
   * Tests.System.SmalltalkImageTest.testImageName

Easy to fix, pending question:
   * FileSystem.Tests.Disk.DiskFileSystemTest.testRootIsNotAFile
     DiskStore>>isFile:
       ...
       aPath isRoot ifTrue: [ ^ true ].
     easy fix, but which is wrong - the test or the implementation?

Remaining to be fixed:
   *  
RPackage.Tests.RPackageImportFromPackageInfoTest.testImportExtensionFromParentPackageRegisterExtensionInParentPackage
   * SUnit.Tests.Core.SUnitTest.testDialectLocalizedException
   * Tests.Traits.TraitTest.testTraitsMethodClassSanity



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6069 by [hidden email]: Test guard for 20132
http://code.google.com/p/pharo/issues/detail?id=6069

Thanks :) now I my bed resting :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 6069 by [hidden email]: Test guard for 20132
http://code.google.com/p/pharo/issues/detail?id=6069

Thanks :) now I my bed resting :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6069 by marianopeck: Test guard for 20132
http://code.google.com/p/pharo/issues/detail?id=6069

sean, I am trying to review this issue, but I have several conflicts and I  
am not sure which are the real changes :(



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: marianopeck [hidden email]

Comment #5 on issue 6069 by [hidden email]: Test guard for 20132
http://code.google.com/p/pharo/issues/detail?id=6069

Damn, our progress is too fast! Most of the slice rotted away. I made a new  
one with the few changes that are still relevant...

I cc-ed cami bc he last worked on some of the changed methods, so I want to  
make sure we're in agreement...

Fix in inbox: SLICE-Issue-6069-Test-guard-for-20132-SeanDeNigris.2

* Change back SmalltalkImage>>imagePath to return the path to the image  
folder. It had been changed to that of the image file itself, but there is  
no issue, so assume it's a bug.
* Change ZipArchiveMember and tests to pass/return aDateAndTime for the  
modifcation timestamp.
* Fix the order of #assert:equals:, making the test pass


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6069 by [hidden email]: Test guard for 20132
http://code.google.com/p/pharo/issues/detail?id=6069

will take a look at it at our mini sprint today


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 6069 by [hidden email]: Test guard for 20132
http://code.google.com/p/pharo/issues/detail?id=6069

imagePath change should be rejected, because it is not what image is  
expecting (it says path, but it needs an image name)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #8 on issue 6069 by [hidden email]: Test guard for 20132
http://code.google.com/p/pharo/issues/detail?id=6069

in 20153


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker