Issue 6073 in pharo: Make PragmaCollector rely on SystemAnnouncer instead of SystemChangeNotifier

Status: FixReviewNeeded
Owner: [hidden email]
Labels: Type-Cleanup Milestone-2.0 Difficulty-Easy

New issue 6073 by [hidden email]: Make PragmaCollector rely on  
SystemAnnouncer instead of SystemChangeNotifier
http://code.google.com/p/pharo/issues/detail?id=6073

that

Attachments:
        pragma collector system notifications.cs  797 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6073 by [hidden email]: Make PragmaCollector  
rely on SystemAnnouncer instead of SystemChangeNotifier
http://code.google.com/p/pharo/issues/detail?id=6073

And I think this should be executed before the changeset is installed:

PragmaCollector allInstances
        do: [ :i | SystemChangeNotifier uniqueInstance noMoreNotificationsFor: i ].

and this afterwards

PragmaCollector allInstances
        do: [ :i | i installSystemNotifications ].


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #2 on issue 6073 by marianopeck: Make PragmaCollector rely on  
SystemAnnouncer instead of SystemChangeNotifier
http://code.google.com/p/pharo/issues/detail?id=6073

I have just reviewed the issue and looks ok to me.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #3 on issue 6073 by marianopeck: Make PragmaCollector rely on  
SystemAnnouncer instead of SystemChangeNotifier
http://code.google.com/p/pharo/issues/detail?id=6073

Sorry, actually I forgot to say that we should also remove PragmaCollector  
>> event:



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 6073 by marianopeck: Make PragmaCollector rely on  
SystemAnnouncer instead of SystemChangeNotifier
http://code.google.com/p/pharo/issues/detail?id=6073

actually, it is crappy tool to see the changes of a .cs. In fact, the .cs  
does remove #event. So it is fine.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6073 by [hidden email]: Make PragmaCollector  
rely on SystemAnnouncer instead of SystemChangeNotifier
http://code.google.com/p/pharo/issues/detail?id=6073

in 20134


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #6 on issue 6073 by [hidden email]: Make PragmaCollector  
rely on SystemAnnouncer instead of SystemChangeNotifier
http://code.google.com/p/pharo/issues/detail?id=6073

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker