Issue 6086 in pharo: Running tests with test runner is very slow due to progress bar

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 6086 by [hidden email]: Running tests with test runner is  
very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

Running tests with test runner is very slow due to progress bar

This really slows down test running *a lot*. I mean, *a lot*.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6086 by [hidden email]: Running tests with test  
runner is very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

Yes, I noticed that too.

At least we have some nice animations to look at ;-)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6086 by [hidden email]: Running tests with test  
runner is very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

There's already the running totals in the TestRunner. Why not disable them  
completely?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 6086 by marianopeck: Running tests with test runner is  
very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

Hi Sean. Even if we can disable them in the test runner, I think we should  
measure the progress bar and see if it can be improved. I guess that in  
certain scenario it won't be able to be disabled and its speed may be a  
problem.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6086 by [hidden email]: Running tests with test  
runner is very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

@Mariano: yes, definitely. The progress bar could use a continued overhaul.  
My fix was intended to be only the first step. A block was being passed  
around as a pseudo-class, which made everything very confusing.

One experiment I wanted to do was create a progress model class that sends  
out announcements, so the progress bar can just [un]subscribe to  
disable/enable...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #5 on issue 6086 by marianopeck: Running tests with test runner is  
very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

Hi Sean. Interesting. I remembers me some discussion with the progress bar  
in Fuel....do you remember?  Martin?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #6 on issue 6086 by [hidden email]: Running tests with test  
runner is very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

it's not the progress bar directly.. it is #updateUIBlock

the attached version does not show each test executed, but then the tests  
are *very* fast.

Attachments:
        TestRunner-updateUIBlock.st  333 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 6086 by [hidden email]: Running tests with test  
runner is very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

indeed a full ui refresh is quite an overload... we need an update maybe  
every 100ms or so


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 6086 by [hidden email]: Running tests with test  
runner is very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

@Mariano, what I did in fuel progress bar was kind of Camillo's idea:  
filter too close bar updates, thus don't update ui more than once each  
100ms (actually AFAIR 250ms)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 6086 by [hidden email]: Running tests with test  
runner is very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

Right now, SystemProgressItemMorph>>changed has 25ms hardcoded, but this  
could be made configurable...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Difficulty-Easy

Comment #10 on issue 6086 by [hidden email]: Running tests with test  
runner is very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

The fix seems okay...
Experiment: a group of tests took 22 secs before and 10 seconds after the  
fix

A few tweaks: the formatting of the block is unusual and the final return  
statement is unnecessary...
     updateUIBlock
        testAnnouncementBlock ifNil: [
                testAnnouncementBlock :=  [: announcement |
                                                        self updateStatus: true.
                                        ]
        ].
        ^ testAnnouncementBlock.

could be:
     updateUIBlock
        ^ testAnnouncementBlock ifNil: [
                testAnnouncementBlock :=  [ :announcement | self updateStatus: true ] ].

A slice with the second version is in the inbox:  
SLICE-Issue-6086-Running-tests-with-test-runner-is-very-slow-due-to-progress-bar-SeanDeNigris.1
* To speed up tests in TestRunner, don't show progress morph for each test


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 6086 by [hidden email]: Running tests with test  
runner is very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

yess!!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #12 on issue 6086 by [hidden email]: Running tests with test  
runner is very slow due to progress bar
http://code.google.com/p/pharo/issues/detail?id=6086

in 20158


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker