Issue 6091 in pharo: FileReference>>extension should be after last separator

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Difficulty-Easy Milestone-2.0

New issue 6091 by [hidden email]: FileReference>>extension should be  
after last separator
http://code.google.com/p/pharo/issues/detail?id=6091

 From discussion  
(http://forum.world.st/FileSystem-and-file-extensions-td4635256.html):
Why not
     #('foo' 'foo.tar' 'foo.tar.gz' 'foo.1.tar' 'foo.1.tar.gz') collect:  
[:thing| thing extension] => #('' 'tar' 'gz' 'tar' 'gz')
and
     #('foo' 'foo.tar' 'foo.tar.gz' 'foo.1.tar' 'foo.1.tar.gz') collect:  
[:thing| thing extensions] => #(#() #('tar') #('gz' 'tar') #('tar' '1')  
#('gz' 'tar' '1'))
or
     #('foo' 'foo.tar' 'foo.tar.gz' 'foo.1.tar' 'foo.1.tar.gz') collect:  
[:thing| thing extensions] => #(#() #('tar') #('tar' 'gz') #('1' 'tar')  
#('1' 'tar' 'gz'))

Everyone seems to agree on #extension, no one yet offered an opinion on  
which #extensions...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Issue 6091: FileReference>>extension should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091

This issue is now blocking issue pharo:6084.
See http://code.google.com/p/pharo/issues/detail?id=6084

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #2 on issue 6091 by [hidden email]:  
FileReference>>extension should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091

We with Camille added the extensions message answering the extensions in  
the order they appear in the file.

#extension remains as it is because we think the extension is the whole  
thing.

We did not adapt users yet because we found some bugs in some tools.  That  
will come in another issue.

Attachments:
        extensions.cs  224 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 6091 by [hidden email]:  
FileReference>>extension should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091

This last one mantains the FileReference and FileLocator polymorphic

Attachments:
        extensions.2.cs  346 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #4 on issue 6091 by [hidden email]: FileReference>>extension  
should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091

in 20155


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6091 by [hidden email]: FileReference>>extension  
should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091

Ahh!! What happened?! There was consensus in the mailing list that the  
extension was the thing after the last dot.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: NextActionNeeded

Comment #6 on issue 6091 by [hidden email]: FileReference>>extension  
should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091

If we want to make #extension the after the last extension delimiter,  
there's a fix in the inbox...
Then we would have (e.g. "CommandShell-Piping-dtl.10.mcz":
- #basename -> CommandShell-Piping-dtl.10.mcz "the entire name"
- #base -> CommandShell-Piping-dtl "the part before any extension  
delimiters"
- #basenameWithoutExtension -> CommandShell-Piping-dtl.10 "the part before  
the last extension
- #extension -> mcz "the last extension"
- #extensions -> an OrderedCollection('10' 'mcz')

That seems like every conceivable interesting combination

n.b. this slice is not related to the first one for this issue, which has  
already been integrated. I successfully loaded it into #20156 and updated  
the FS tests, which all pass
SLICE-Issue-6091-FileReferencegtgtextension-should-be-after-last-separator-SeanDeNigris.1

Make #extension in FS return the part after the last extension delimiter


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 6091 by [hidden email]: FileReference>>extension  
should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091

OkI'm looking at it. (I'm stopped at home because of pre-burnout... :( ...  
but pharo is fun).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #8 on issue 6091 by [hidden email]: FileReference>>extension  
should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091

in 20158.
Indeed we stopped in the middle yesterday.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #9 on issue 6091 by [hidden email]: FileReference>>extension  
should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091#c9

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #10 on issue 6091 by [hidden email]:  
FileReference>>extension should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091#c10

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6091-FileReferencegtgtextension-should-be-after-last-separator-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox:
        UndeclaredVariableWarning
  1: EncoderForV3PlusClosures(Encoder)>>undeclared:
  2: Parser>>correctVariable:interval:
  3: [self
                        correctVariable: varName
                        interval: (varStart to: varEnd)] in Parser>>variable
  4: [(self
                                lookupInPools: name
                                ifFound: [:assoc | varNode := self global: assoc name: name])
                        ifTrue: [varNode]
                        ifFalse: [^ action value]] in  
EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  5: Dictionary>>at:ifAbsent:
  6: EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  7: Parser>>variable
  8: Parser>>primaryExpression
  9: Parser>>messagePart:repeat:
10: Parser>>messagePart:repeat:
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6091-FileReferencegtgtextension-should-be-after-last-separator-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox
        "extensions.cs" from Comment #2
        "extensions.2.cs" from Comment #3
Tested using Pharo-2.0-20172-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #11 on issue 6091 by [hidden email]:  
FileReference>>extension should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091

in 2.0 158


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #12 on issue 6091 by [hidden email]:  
FileReference>>extension should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091#c12

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #13 on issue 6091 by [hidden email]:  
FileReference>>extension should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091#c13

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6091-FileReferencegtgtextension-should-be-after-last-separator-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox:
        UndeclaredVariableWarning
  1: EncoderForV3PlusClosures(Encoder)>>undeclared:
  2: Parser>>correctVariable:interval:
  3: [self
                        correctVariable: varName
                        interval: (varStart to: varEnd)] in Parser>>variable
  4: [(self
                                lookupInPools: name
                                ifFound: [:assoc | varNode := self global: assoc name: name])
                        ifTrue: [varNode]
                        ifFalse: [^ action value]] in  
EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  5: Dictionary>>at:ifAbsent:
  6: EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  7: Parser>>variable
  8: Parser>>primaryExpression
  9: Parser>>messagePart:repeat:
10: Parser>>messagePart:repeat:
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6091-FileReferencegtgtextension-should-be-after-last-separator-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox
        "extensions.cs" from Comment #2
        "extensions.2.cs" from Comment #3
Tested using Pharo-2.0-20172-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #14 on issue 6091 by [hidden email]:  
FileReference>>extension should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091#c14

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #15 on issue 6091 by [hidden email]:  
FileReference>>extension should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091#c15

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6091-FileReferencegtgtextension-should-be-after-last-separator-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox:
        UndeclaredVariableWarning
  1: EncoderForV3PlusClosures(Encoder)>>undeclared:
  2: Parser>>correctVariable:interval:
  3: [self
                        correctVariable: varName
                        interval: (varStart to: varEnd)] in Parser>>variable
  4: [(self
                                lookupInPools: name
                                ifFound: [:assoc | varNode := self global: assoc name: name])
                        ifTrue: [varNode]
                        ifFalse: [^ action value]] in  
EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  5: Dictionary>>at:ifAbsent:
  6: EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  7: Parser>>variable
  8: Parser>>primaryExpression
  9: Parser>>messagePart:repeat:
10: Parser>>messagePart:repeat:
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6091-FileReferencegtgtextension-should-be-after-last-separator-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox
        "extensions.cs" from Comment #2
        "extensions.2.cs" from Comment #3
Tested using Pharo-2.0-20172-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #16 on issue 6091 by [hidden email]:  
FileReference>>extension should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091#c16

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #17 on issue 6091 by [hidden email]:  
FileReference>>extension should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091#c17

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6091-FileReferencegtgtextension-should-be-after-last-separator-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox:
        UndeclaredVariableWarning
  1: EncoderForV3PlusClosures(Encoder)>>undeclared:
  2: Parser>>correctVariable:interval:
  3: [self
                        correctVariable: varName
                        interval: (varStart to: varEnd)] in Parser>>variable
  4: [(self
                                lookupInPools: name
                                ifFound: [:assoc | varNode := self global: assoc name: name])
                        ifTrue: [varNode]
                        ifFalse: [^ action value]] in  
EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  5: Dictionary>>at:ifAbsent:
  6: EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  7: Parser>>variable
  8: Parser>>primaryExpression
  9: Parser>>messagePart:repeat:
10: Parser>>messagePart:repeat:
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6091-FileReferencegtgtextension-should-be-after-last-separator-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox
        "extensions.cs" from Comment #2
        "extensions.2.cs" from Comment #3
Tested using Pharo-2.0-20172-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #18 on issue 6091 by [hidden email]:  
FileReference>>extension should be after last separator
http://code.google.com/p/pharo/issues/detail?id=6091

in 2.0 158


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker