Issue 6092 in pharo: Clean Chronology tests

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 6092 by [hidden email]: Clean Chronology tests
http://code.google.com/p/pharo/issues/detail?id=6092

Pharo2.0a
Latest update: #20142

The tests are a mess. They are unclear and there is a lot of duplication.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6092 by [hidden email]: Clean Chronology tests
http://code.google.com/p/pharo/issues/detail?id=6092

Since there is a lot to do, this first part focuses on DateTest. Once this  
is integrated, I'll do a second pass...

Fix in inbox: SLICE-Issue-6092-Clean-Chronology-tests-SeanDeNigris.1

DateTest
- refactor many tests. They were unclear (e.g. magic constants), contained  
a lot of duplication and unnecessary assertions (non-interesting cases)
- create DatePrintFormatTester helper class to test print formatting  
methods. The print format stuff is *very* confusing
DateAndTimeTest
- Put methods in correct protocols
- Add failing epoch tests (they should be failing for now)
TimestampTest - remove #testFromSeconds, which is tested in the superclass
- Create TDateTimeTest trait to adjust the local offset during tests



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #2 on issue 6092 by [hidden email]: Clean Chronology tests
http://code.google.com/p/pharo/issues/detail?id=6092

In 20158. Thanks!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker