Issue 6114 in pharo: FileDialogWindow fails to open in Monticello Browser

Status: New
Owner: ----
Labels: Milestone-2.0 Type-Bug

New issue 6114 by [hidden email]: FileDialogWindow fails to open in  
Monticello Browser
http://code.google.com/p/pharo/issues/detail?id=6114

This broke during the migration to FileSystem (worked in 20119, failed in  
20129 and after).
Attempting to add a new directory repository in Monticello Browser fails to  
create the FileDialogWindow, since FileDirectoryWrapper>>asString asks  
itemName translatedIfCorresponds, but itemName is nil. Either asString  
should be

asString
^ item baseName translatedIfCorresponds

or FileDialogWindow>>initialDirectories should be modified to use  
with:name:model: in place of with:model: when populating the directory  
list, which currently leaves name nil.

Changing asString seems to fix this problem, but I don't know if it breaks  
anything else. Also, I'm far from certain that item basename is the right  
choice.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Cc: [hidden email]

Comment #1 on issue 6114 by [hidden email]: FileDialogWindow fails  
to open in Monticello Browser
http://code.google.com/p/pharo/issues/detail?id=6114

Fix in inbox: Name:  
SLICE-Issue-6114-FileDialogWindow-fails-to-open-in-Monticello-Browser-SeanDeNigris.1

Fix FileDialogWindow, which got broken when being translated to FS


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #2 on issue 6114 by [hidden email]: FileDialogWindow fails  
to open in Monticello Browser
http://code.google.com/p/pharo/issues/detail?id=6114

Hi sean
I integrated this change in 2020157 but I saw that guillermo also worked on  
it yesterday so this is probably good that you have a look.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email] [hidden email]

Comment #3 on issue 6114 by [hidden email]: FileDialogWindow fails  
to open in Monticello Browser
http://code.google.com/p/pharo/issues/detail?id=6114

@Steph: I'm not sure what to look at... Is there an issue for Guille's work?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6114 by [hidden email]: FileDialogWindow  
fails to open in Monticello Browser
http://code.google.com/p/pharo/issues/detail?id=6114

Hi Sean, have a look at the slice for issue 6125... we overlapped a bit


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker