Issue 6138 in pharo: AbsolutePath not absolute on Windows

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 6138 by [hidden email]: AbsolutePath not absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138

(AbsolutePath from: 'c:\test.txt') class

returns RelativePath on Windows instead of AbsolutePath. This is clearly
a bug and was introduced with "FileSystem-Core-StephaneDucasse.14.mcz"

Therefore please add these two test case methods to class PathTest

testUnixAbsolutePathName
   self assert: (Path from: '/test') isAbsolute

testWindowsAbsolutePathName
   self assert: (Path from: 'c:\test') isAbsolute

and you will see that the last one is red and has to be fixed.


The problem is the method Path>>from:delimiter where class AbsolutePath
is only used when the path string starts with "/".
This is true for Unix but NOT FOR WINDOWS path names.

So currently it returns RelativePath but "C:\test" is not a relative
path on Windows.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138

I think esteban fixed that today?

Did you update the image completly? (we did quite some integrations  
today :))


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138

Issue 6137 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Filesystem

Comment #3 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6138 by [hidden email]: AbsolutePath not absolute  
on Windows
http://code.google.com/p/pharo/issues/detail?id=6138

Esteban only solved the problem with CI building for Windows.

If you run the above tests you will see yourself that it is not yet fixed.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #5 on issue 6138 by [hidden email]: AbsolutePath not absolute  
on Windows
http://code.google.com/p/pharo/issues/detail?id=6138

Attached is a proposed fix together with a test suite. Please review and  
include if OK

Attachments:
        ProposedFix.cs  1.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #6 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138#c6

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #7 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138#c7

Monkey went bananas:
--------------------
Error while loading "ProposedFix.cs" from Comment #5:
        MessageNotUnderstood: ReadStream>>fileIn
  1: ReadStream(Object)>>doesNotUnderstand: #fileIn
  2: [attachment contents asString readStream fileIn] in [:attachment |  
[attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
ChangeLoader>>loadChangeSet
  3: BlockClosure>>on:do:
  4: [:attachment | [attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
ChangeLoader>>loadChangeSet
  5: Array(SequenceableCollection)>>do:
  6: ChangeLoader>>loadChangeSet
  7: [self loadChangeSet] in ChangeLoader>>loadAndTestChangeSet
  8: [loadStopwatch reset activate.
                aBlock value.
                loadStopwatch suspend.
                testResult := self runTests.
                self removeFalseErrors] in ChangeLoader>>testChangeImpact:
  9: BlockClosure>>on:do:
10: ChangeLoader>>testChangeImpact:
        ...
----------------------------------------------------------
Loaded Source: "ProposedFix.cs" from Comment #5
Tested using Pharo-2.0-20172-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #8 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138

Name: SLICE-Issue-6138-AbsolutePath-not-absolute-on-Windows-MarcusDenker.1
Author: MarcusDenker
Time: 2 July 2012, 8:28:23.902 am
UUID: 0388e8e4-f97b-42a6-8c1a-19b7186f029f
Ancestors:
Dependencies: FileSystem-Tests-Core-MarcusDenker.24,  
FileSystem-Core-MarcusDenker.30

Issue 6138: AbsolutePath not absolute on Windows


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #9 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138#c9

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey

Comment #10 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138#c10

This Issue has been checked by Ulysse the Monkey
       
5287 tests passed in 00:00:21s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (907)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (592)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        FileSystem-Tests-Core (184)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6138-AbsolutePath-not-absolute-on-Windows-MarcusDenker.1 from  
http://ss3.gemstone.com/ss/PharoInbox"ProposedFix.cs" from Comment #5
Tested using Pharo-2.0-20176-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #11 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138#c11

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FailingTest

Comment #12 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138#c12

Test Results:
-------------
Passed: 5286
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (592)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        FileSystem-Tests-Core (184)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)


Failures: 1
        SharedQueue2Test>>#testCounting

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6138-AbsolutePath-not-absolute-on-Windows-MarcusDenker.1 from  
http://ss3.gemstone.com/ss/PharoInbox"ProposedFix.cs" from Comment #5
Tested using Pharo-2.0-20176-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #13 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #14 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138#c14

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20178

Comment #15 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138#c15

This Issue has been checked by Ulysse the Monkey
       
6511 tests passed in 00:02:16s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (907)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        FileSystem-Tests-Core (184)
        KernelTests-Chronology (577)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6138-AbsolutePath-not-absolute-on-Windows-MarcusDenker.1 from  
http://ss3.gemstone.com/ss/PharoInbox"ProposedFix.cs" from Comment #5
Tested using Pharo-2.0-20178-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jul  3 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jul  3 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #16 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138

looks good


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #17 on issue 6138 by [hidden email]: AbsolutePath not  
absolute on Windows
http://code.google.com/p/pharo/issues/detail?id=6138

in 2.0 179


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker