Issue 6148 in pharo: realClass part of Ring

Status: FixReviewNeeded
Owner: [hidden email]
Labels: Type-Bug

New issue 6148 by [hidden email]: realClass part of Ring
http://code.google.com/p/pharo/issues/detail?id=6148

The CompiledMethod >> realClass makes unwelcome dependency of kernel  
packages on Ring. It is not possilbe to compile some classes with Traits  
without this message. This message has general purpose and is not Ring  
specific so this patch moves it to 'accessing' category

Attachments:
        realClassPatch.st  69 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6148 by marianopeck: realClass part of Ring
http://code.google.com/p/pharo/issues/detail?id=6148

Hi Pavel. As you know, previously, we had a problem where traits were  
depending on Traits, and I fixed that. Now you say "It is not possilbe to  
compile some classes with Traits without this message". Can you tell us  
which is that stack of messages? I mean, which is the sender of #realClass  
that has the problem?   because only Ring shoud be sending that message.  
But I removed the dependency of traits on Ring, so I don't understand.....  
Users that are not Ring should be using #methodClass instead of #realClass.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6148 by marianopeck: realClass part of Ring
http://code.google.com/p/pharo/issues/detail?id=6148

So, I think:

TraitComposition >> traitProvidingSelector:
TPureBehavior >> traitsProvidingSelector:

should use #methodClass instead of #realClass


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-2.0

Comment #3 on issue 6148 by marianopeck: realClass part of Ring
http://code.google.com/p/pharo/issues/detail?id=6148

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6148 by marianopeck: realClass part of Ring
http://code.google.com/p/pharo/issues/detail?id=6148

and btw...I think that #realClass should do not duplicate code and instead  
do:

CompiledMethod >> realClass
^ self methodClass


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6148 by [hidden email]: realClass part of Ring
http://code.google.com/p/pharo/issues/detail?id=6148

here is the failure case while loading collections tests

Attachments:
        PharoDebug.log  8.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6148 by [hidden email]: realClass part of Ring
http://code.google.com/p/pharo/issues/detail?id=6148

the patch works with
^ self methodClass


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Labels: -Type-Bug Type-Enh

Comment #7 on issue 6148 by marianopeck: realClass part of Ring
http://code.google.com/p/pharo/issues/detail?id=6148

Fix in inbox.

Name: SLICE-Issue-6148-realClass-part-of-Ring-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 26 June 2012, 10:41:54.534 am
UUID: d0b324ad-3a94-495a-9e47-dd62eac53668
Ancestors:
Dependencies: Traits-MarianoMartinezPeck.421,  
Ring-Core-Kernel-MarianoMartinezPeck.62

fix to issue 6148


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 6148 by [hidden email]: realClass part of  
Ring
http://code.google.com/p/pharo/issues/detail?id=6148

it's ok :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #9 on issue 6148 by [hidden email]: realClass part of Ring
http://code.google.com/p/pharo/issues/detail?id=6148

in 2.0 161


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker