Status: Accepted
Owner: ---- Labels: Type-Defect Priority-Medium RPackage New issue 619 by [hidden email]: RPackage should deal with unknown extensions http://code.google.com/p/moose-technology/issues/detail?id=619 In MC we have - AST-Core - AST-Semantic but no - AST-Compiler- whatever so when we get *AST-Compiler-Overrides..... clearly this is a problem. We should create a new package with the extension names. _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Comment #1 on issue 619 by [hidden email]: RPackage should deal with unknown extensions http://code.google.com/p/moose-technology/issues/detail?id=619 Indeed, I think this is a good idea. _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Updates:
Labels: -RPackage component-r Comment #2 on issue 619 by [hidden email]: RPackage should deal with unknown extensions http://code.google.com/p/moose-technology/issues/detail?id=619 (No comment was entered for this change.) _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Updates:
Labels: -component-r Component-RPackage Comment #3 on issue 619 by [hidden email]: RPackage should deal with unknown extensions http://code.google.com/p/moose-technology/issues/detail?id=619 (No comment was entered for this change.) _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Updates:
Cc: [hidden email] Comment #4 on issue 619 by [hidden email]: RPackage should deal with unknown extensions http://code.google.com/p/moose-technology/issues/detail?id=619 this is in essence what the code was doing. The halt is just to indetify the problem. I will check the implementation and we should add a test. packageFromOrganizer: anRPackageOrganizer self flag: #cyrille. "If the organizer is not able to find the package of a method, it is surely because something went wrong at one point. I got into that situation when having RPackage listening to the system. So a solution I have for now (this is maybe not the best one), is to check if the method is registered in RPackage, and if it is not, simulate a addMethod event to update the organizer. Specific behavior in RPackageOrganizer >> systemMethodRemovedActionFrom: " self methodClass packages detect: [:each | each includesSelector: self selector ofClass: self methodClass ] ifNone: [ self flag: 'should not arrive there now'. self halt. self category isNil ifTrue: [Error signal]. anRPackageOrganizer systemMethodAddedActionFrom: (AddedEvent method: self selector: self selector protocol: self category class: self methodClass) asSystemAnnouncement. ]. ^ anRPackageOrganizer packageDefiningOrExtendingMethod: self _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Comment #5 on issue 619 by [hidden email]: RPackage should deal with unknown extensions http://code.google.com/p/moose-technology/issues/detail?id=619 I think RPackage currently deals with such extensions. In RPackageOrganizer >> systemMethodAddedActionFrom: we have this code: rPackage := (self packageMatchingExtensionName: extendingPackageName) ifNil: [ "If the extension name does not match with any registered package, we create a new one, and add the method in this one. This is how monticello does." "class package" self registerPackage: (RPackage named: extendingPackageName). ]. Now RPackageOrganizer >> packageMatchingExtensionName: start from the full name of the extension and if he does not find, recusively look for a 'smaller subcategory name'. Return nil if find nothing at the end. This looks correct ? _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Comment #6 on issue 619 by [hidden email]: RPackage should deal with unknown extensions http://code.google.com/p/moose-technology/issues/detail?id=619 I will sit with you. Stef _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Comment #7 on issue 619 by [hidden email]: RPackage should deal with unknown extensions http://code.google.com/p/moose-technology/issues/detail?id=619 How do we stand on this? _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Updates:
Labels: Milestone-4.6 Comment #8 on issue 619 by [hidden email]: RPackage should deal with unknown extensions http://code.google.com/p/moose-technology/issues/detail?id=619 Is this still an issue? _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Comment #9 on issue 619 by [hidden email]: RPackage should deal with unknown extensions http://code.google.com/p/moose-technology/issues/detail?id=619 Cyrille, I guess this is solved now, right? :) _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Updates:
Status: Fixed Comment #10 on issue 619 by [hidden email]: RPackage should deal with unknown extensions http://code.google.com/p/moose-technology/issues/detail?id=619 Yes this is fixed. I mark this issue as 'fixed' _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Free forum by Nabble | Edit this page |