Issue 6192 in pharo: [Bug]: FileReference>>#extension causes error if no extension

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0 Difficulty-Easy

New issue 6192 by [hidden email]: [Bug]: FileReference>>#extension  
causes error if no extension
http://code.google.com/p/pharo/issues/detail?id=6192

Pharo2.0a
Latest update: #20167

DoIt: "(FileSystem memory * 'fileWithoutExtension') extension" -> error


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6192 by [hidden email]: [Bug]:  
FileReference>>#extension causes error if no extension
http://code.google.com/p/pharo/issues/detail?id=6192

Fix in inbox:  
SLICE-Issue-6192-Bug-FileReferencegtgtextension-causes-error-if-no-extension-SeanDeNigris.1

* Fix #extension in FileReference, FileLocator, and Path to return an empty  
string if there is no extension, instead of signaling an error
* Add test for FileReference>>extension with no extension


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6192 by [hidden email]: [Bug]:  
FileReference>>#extension causes error if no extension
http://code.google.com/p/pharo/issues/detail?id=6192#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #3 on issue 6192 by [hidden email]: [Bug]:  
FileReference>>#extension causes error if no extension
http://code.google.com/p/pharo/issues/detail?id=6192#c3

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6192-Bug-FileReferencegtgtextension-causes-error-if-no-extension-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox:
        UndeclaredVariableWarning
  1: EncoderForV3PlusClosures(Encoder)>>undeclared:
  2: Parser>>correctVariable:interval:
  3: [self
                        correctVariable: varName
                        interval: (varStart to: varEnd)] in Parser>>variable
  4: [(self
                                lookupInPools: name
                                ifFound: [:assoc | varNode := self global: assoc name: name])
                        ifTrue: [varNode]
                        ifFalse: [^ action value]] in  
EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  5: Dictionary>>at:ifAbsent:
  6: EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  7: Parser>>variable
  8: Parser>>primaryExpression
  9: Parser>>messagePart:repeat:
10: Parser>>messagePart:repeat:
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6192-Bug-FileReferencegtgtextension-causes-error-if-no-extension-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20172-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #4 on issue 6192 by [hidden email]: [Bug]:  
FileReference>>#extension causes error if no extension
http://code.google.com/p/pharo/issues/detail?id=6192

The monkey didn't like my slice, so I made a new one off of #20172:  
SLICE-Issue-6192-Bug-FileReferencegtgtextension-causes-error-if-no-extension-SeanDeNigris.2


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #5 on issue 6192 by [hidden email]: [Bug]:  
FileReference>>#extension causes error if no extension
http://code.google.com/p/pharo/issues/detail?id=6192#c5

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 6192 by [hidden email]: [Bug]:  
FileReference>>#extension causes error if no extension
http://code.google.com/p/pharo/issues/detail?id=6192#c6

This Issue has been checked by Ulysse the Monkey
       
5345 tests passed in 00:00:10s:
===============================
        CollectionsTests-Arrayed (562)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (907)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (592)
        CollectionsTests-Support (12)
        CollectionsTests-Text (45)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        FileSystem-Tests-Core (182)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6192-Bug-FileReferencegtgtextension-causes-error-if-no-extension-SeanDeNigris.2  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20172-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 6192 by [hidden email]: [Bug]:  
FileReference>>#extension causes error if no extension
http://code.google.com/p/pharo/issues/detail?id=6192

in 2.0 174


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker