Issue 6203 in pharo: Spotlight improvement

Status: Accepted
Owner: [hidden email]
Labels: Type-Feature Milestone-2.0

New issue 6203 by [hidden email]: Spotlight improvement
http://code.google.com/p/pharo/issues/detail?id=6203

- Add lostFocus on Morph
- Reduce the number of classes used
- Change the default color (use UITheme now)
- When focus is lost, delete
- Move some method from SmalltalkEditor to TextEditor

Slice is incoming


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6203 by [hidden email]: Spotlight improvement
http://code.google.com/p/pharo/issues/detail?id=6203

Slice in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6203 by [hidden email]: Spotlight improvement
http://code.google.com/p/pharo/issues/detail?id=6203

New version posted in accordance of the fixes done in the mid time


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #3 on issue 6203 by [hidden email]: Spotlight improvement
http://code.google.com/p/pharo/issues/detail?id=6203

I get a conflict for #newKeyboardFocus


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6203 by [hidden email]: Spotlight improvement
http://code.google.com/p/pharo/issues/detail?id=6203

Yep, I added a space so the merge create a conflict :s
The second version of the slide is correct.

Nevertheless, I will check that :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #5 on issue 6203 by [hidden email]: Spotlight improvement
http://code.google.com/p/pharo/issues/detail?id=6203#c5

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #6 on issue 6203 by [hidden email]: Spotlight improvement
http://code.google.com/p/pharo/issues/detail?id=6203#c6

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6203-Spotlight-improvement-BenjaminVanRyseghem.2 from  
http://ss3.gemstone.com/ss/PharoInbox:
        Warning: This package depends on the following classes:
   ImmX11
   ImmWin32
You must resolve these dependencies before you will be able to load these  
definitions:
   keyboardFocusForAMorph:
   keyboardFocusForAMorph:
   setCompositionWindowPositionX:y:
  1: MCMultiPackageLoader(Object)>>notify:
  2: MCMultiPackageLoader(MCPackageLoader)>>warnAboutDependencies
  3: MCMultiPackageLoader(MCPackageLoader)>>loadWithNameLike:
  4: MCVersionLoader>>loadWithNameLike:
  5: MCVersionLoader>>load
  6: GoferLoad>>execute
  7: Gofer>>execute:do:
  8: Gofer>>execute:
  9: Gofer>>load
10: GoferResolvedReference>>load
        ...
----------------------------------------------------------
Loaded Source: SLICE-Issue-6203-Spotlight-improvement-BenjaminVanRyseghem.2  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20172-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #7 on issue 6203 by [hidden email]: Spotlight improvement
http://code.google.com/p/pharo/issues/detail?id=6203

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #8 on issue 6203 by [hidden email]: Spotlight improvement
http://code.google.com/p/pharo/issues/detail?id=6203#c8

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #9 on issue 6203 by [hidden email]: Spotlight improvement
http://code.google.com/p/pharo/issues/detail?id=6203#c9

This Issue has been checked by Ulysse the Monkey
       
5242 tests passed in 00:00:12s:
===============================
        CollectionsTests-Arrayed (562)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (907)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (592)
        CollectionsTests-Support (12)
        CollectionsTests-Text (45)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        MorphicTests-Basic (16)
        MorphicTests-Event (7)
        MorphicTests-Kernel (8)
        MorphicTests-Text Support (4)
        MorphicTests-Widgets (3)
        MorphicTests-WindowNotification (8)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-TextEditors (3)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)

----------------------------------------------------------
Loaded Source: SLICE-Issue-6203-Spotlight-improvement-BenjaminVanRyseghem.3  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20172-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.160 uuid:  
bec8cdf0-4e06-4975-8c02-e882fadf4df3 Jun 22 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
744bfe905c78a1a5d408680a8780367ea77e0549 Date: Fri Jun 1 15:17:41 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 6203 by [hidden email]: Spotlight improvement
http://code.google.com/p/pharo/issues/detail?id=6203

in 2.0 173


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker